Update to Java 11

[chetanmeh]

We should plan to move to Open JDK 11 which is the next LTS release. This issue is meant to track relevant work required to support that

• Scala - Per current compatibility matrix JDK 11 looks like still not supported. See Java 11 testing scala/scala-dev#559.
• Akka - Would depend on compatible Scala release
• Gradle - Gradle 5.0 supports JDK 11

May be its fine to use latest Scala if the JPMS module support is not required. That would need to be validated

[csantanapr]

Maybe is time to upgrade now?

[chetanmeh]

Tried to run test based on this branch. but build failed for multiple reasons.

Some of the unit tests are failing due to change in behaviour of Instant which is causing Instant in JDK 11 to use microsecond precision while we store the time in db in millis. So when entity instances are reconstructed from db the Instant value differs from one created directly.

See such failed test here. Most failure are due to equality test failing for entities ... most likely due to difference in Instant values.

Other failures are yet not analyzed!

[mcdan]

I've proposed a PR that both jumps us to java 11 and a later scala version. All the travis tests pass but perhaps there is something else I should run?

[rabbah]

LGTM thanks Dan.

[rabbah]

Thanks Dan. I reviewed and approve the PR; it lgtm.

…

-r

On Thu, Oct 31, 2019 at 11:07 AM dan mcweeney ***@***.***> wrote: I've proposed a PR that both jumps us to java 11 and a later scala version. All the travis tests pass but perhaps there is something else I should run? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4217?email_source=notifications&email_token=ABF25MXZRIQTXA4IGMFTZTLQRLYCXA5CNFSM4GQBKC62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECYDZYY#issuecomment-548420835>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABF25MVRBZDAXQIXUF6BXXDQRLYCXANCNFSM4GQBKC6Q> .