-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add write_total_max_size in Capability #3309
Conversation
I prefer addressing this issue from service capability side. |
I'm not sure I understand what you mean. How do we addressing this issue from service capability side? |
I haven't thought about this deeply yet, but perhaps we can consider adding a This way, both users and our tests can determine the maximum size supported by this service. |
@Xuanwo Add new capability attribute |
Signed-off-by: taobo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
The only task here is to make clippy happy: error: using `clone` on type `Capability` which implements the `Copy` trait
--> core/tests/behavior/blocking_write.rs:435:34
|
435 | let (content, _) = gen_bytes(op.info().full_capability().clone());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `op.info().full_capability()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy |
For #3216 , D1 limited the Maximum string, BLOB or table row size to 1M, but gen_bytes() randomly generates
1~4M
content. It will result in the following error:Maybe we can support configuring max_size via environment variable?