Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cloudflare D1 support #3216

Closed
Xuanwo opened this issue Sep 29, 2023 · 6 comments
Closed

Add cloudflare D1 support #3216

Xuanwo opened this issue Sep 29, 2023 · 6 comments
Assignees
@Xuanwo
Labels
services/d1

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Sep 29, 2023 •
edited
Loading

https://developers.cloudflare.com/api/operations/cloudflare-d1-query-database

We can implement D1 support via our KV adaptor
@Xuanwo Xuanwo added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 29, 2023
@poltao
Copy link
Contributor

poltao commented Oct 4, 2023

@Xuanwo I'd like to give it a try, please assign it to me.

@Xuanwo
Copy link
Member Author

Xuanwo commented Oct 4, 2023

Have fun!

This was referenced Oct 9, 2023
Merged
Merged
@poltao
Copy link
Contributor

poltao commented Nov 6, 2023

@Xuanwo This should be closed.

@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 6, 2023

@Xuanwo This should be closed.

We need to setup a behavior test for D1 first.

@poltao
Copy link
Contributor

poltao commented Nov 6, 2023 •
edited
Loading

We need to setup a behavior test for D1 first.

Got it, I'll take care of it later.

@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 6, 2023

Got it, I'll take care of it later.

Thanks a lot first! It's more like a committers' job (since only committer can access secrets).

Let me help address this.

@Xuanwo Xuanwo assigned Xuanwo and unassigned poltao Nov 6, 2023
@Xuanwo Xuanwo added services/d1 and removed good first issue Good for newcomers help wanted Extra attention is needed labels Dec 28, 2023
@Xuanwo Xuanwo closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xuanwo Xuanwo

Labels
services/d1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Xuanwo @poltao