Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[numpy] FFI binary bitwise ops #17812

Merged
merged 2 commits into from
Apr 8, 2020
Merged

Conversation

Yiyan66
Copy link
Contributor

@Yiyan66 Yiyan66 commented Mar 11, 2020

Description

FFI bitwise_and, bitwise_or, bitwise_xor

  Old FFI (ctypes) (us) New FFI (cython) (us)
bitwise_and 20.96 7.34
bitwise_or 21.05 7.21
bitwise_xor 21.1 7.34
copysign 26.08 7.32
arctan2 26.28 7.16
hypot 25.93 7.11
ldexp 26.56 7.24

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@Yiyan66 Yiyan66 requested a review from szha as a code owner March 11, 2020 07:13
@haojin2 haojin2 self-assigned this Mar 11, 2020
@haojin2 haojin2 added the Numpy label Mar 11, 2020
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haojin2 haojin2 self-requested a review March 15, 2020 05:38
@Yiyan66 Yiyan66 force-pushed the ffi_bitwise_binary branch from 1cd1fbf to b0145e8 Compare March 16, 2020 12:59
Copy link
Contributor

@hzfan hzfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yiyan66 Yiyan66 force-pushed the ffi_bitwise_binary branch 2 times, most recently from 57745c8 to 8190f73 Compare March 19, 2020 03:56
@Yiyan66 Yiyan66 force-pushed the ffi_bitwise_binary branch 2 times, most recently from c905608 to 6b899ac Compare April 7, 2020 13:46
@Yiyan66 Yiyan66 force-pushed the ffi_bitwise_binary branch from 6b899ac to 70e44fd Compare April 8, 2020 09:06
@haojin2 haojin2 merged commit d1616c9 into apache:master Apr 8, 2020
sxjscience pushed a commit to sxjscience/mxnet that referenced this pull request Jul 1, 2020
* ffi_bitwise  binary

* retrigger ci
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants