Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #5743][AUTHZ] Improve AccessControlException verification of RangerSparkExtensionSuite #5744

Closed
wants to merge 2 commits into from

Conversation

zml1206
Copy link
Contributor

@zml1206 zml1206 commented Nov 21, 2023

🔍 Description

Issue References 🔗

This pull request fixes #5743.

Describe Your Solution 🔧

Add and use new function AssertionUtils.interceptEndswith.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests

Exists test cases.


Checklists

📝 Author Self Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • This patch was not authored or co-authored using Generative Tooling

📝 Committer Pre-Merge Checklist

  • Pull request title is okay.
  • No license issues.
  • Milestone correctly set?
  • Test coverage is ok
  • Assignees are selected.
  • Minimum number of approvals
  • No changes are requested

Be nice. Be informative.

@zml1206
Copy link
Contributor Author

zml1206 commented Nov 21, 2023

The exception messages of many suites are incomplete. I will resubmit them multiple times according to different stored suites.

@zml1206
Copy link
Contributor Author

zml1206 commented Nov 21, 2023

Delta Lake: #5747

@yaooqinn yaooqinn added this to the v1.9.0 milestone Nov 22, 2023
@yaooqinn
Copy link
Member

Hi @zml1206, could you please assist in getting the CI to turn green? Thank you.

@zml1206
Copy link
Contributor Author

zml1206 commented Nov 22, 2023

Hi @zml1206, could you please assist in getting the CI to turn green? Thank you.

Of course, I will deal with it later.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (111786f) 61.40% compared to head (fe58cc2) 61.41%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5744      +/-   ##
============================================
+ Coverage     61.40%   61.41%   +0.01%     
  Complexity       23       23              
============================================
  Files           607      607              
  Lines         35897    35897              
  Branches       4923     4923              
============================================
+ Hits          22041    22046       +5     
+ Misses        11471    11469       -2     
+ Partials       2385     2382       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yaooqinn yaooqinn closed this in 84a9686 Nov 22, 2023
@yaooqinn
Copy link
Member

thanks, merged to master

@zml1206
Copy link
Contributor Author

zml1206 commented Nov 22, 2023

Thanks, @yaooqinn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK][TRIVIAL] Make AccessControlException verification of RangerSparkExtensionSuite more rigorous
3 participants