[TASK][TRIVIAL] Make AccessControlException verification of RangerSparkExtensionSuite more rigorous #5743
Closed
3 of 4 tasks
Assignees
Comments
yaooqinn
pushed a commit
that referenced
this issue
Nov 22, 2023
…RangerSparkExtensionSuite # 🔍 Description ## Issue References 🔗 This pull request fixes #5743. ## Describe Your Solution 🔧 Add and use new function AssertionUtils.interceptEndswith. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests Exists test cases. --- # Checklists ## 📝 Author Self Checklist - [x] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project - [x] I have performed a self-review - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) ## 📝 Committer Pre-Merge Checklist - [x] Pull request title is okay. - [x] No license issues. - [x] Milestone correctly set? - [x] Test coverage is ok - [x] Assignees are selected. - [x] Minimum number of approvals - [x] No changes are requested **Be nice. Be informative.** Closes #5744 from zml1206/KYUUBI-5743. Closes #5743 fe58cc2 [zml1206] fix a3560b0 [zml1206] Improve AccessControlException verification of RangerSparkExtensionSuite Authored-by: zml1206 <[email protected]> Signed-off-by: Kent Yao <[email protected]>
pan3793
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Code of Conduct
Search before asking
What would you like to be improved?
AssertionUtils.interceptContainsis defective for AccessControlException verification of RangerSparkExtensionSuite.For example, the exception message we expect is
does not have [write] privilege on [[$path, $path/]], but the actual message isdoes not have [write] privilege on [[/tmp/t1, /tmp/ t1/]], [update] privilege on [delta/target],The current implementation is undetectable.
How should we improve?
Add and use new function
AssertionUtils.interceptEndswith.Are you willing to submit PR?
The text was updated successfully, but these errors were encountered: