Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to specify confOverlay when executing statement with RESTful API #4639

Closed
wants to merge 5 commits into from
Closed

Support to specify confOverlay when executing statement with RESTful API #4639

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eb49537
conf overlay
turboFei Mar 30, 2023
f840cb4
conf overlay
turboFei Mar 30, 2023
2fe8a16
save
turboFei Mar 30, 2023
f4f2bc8
doc
turboFei Mar 30, 2023
cdf828f
add ut
turboFei Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion kyuubi-rest-client/src/main/java/org/apache/kyuubi/client/api/v1/dto/StatementRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@

package org.apache.kyuubi.client.api.v1.dto;

import java.util.Collections;
import java.util.Map;
import java.util.Objects;
import org.apache.commons.lang3.builder.ReflectionToStringBuilder;
import org.apache.commons.lang3.builder.ToStringStyle;
Expand All @@ -25,13 +27,16 @@ public class StatementRequest {
private String statement;
private boolean runAsync;
private Long queryTimeout;
private Map<String, String> confOverlay;

public StatementRequest() {}

public StatementRequest(String statement, boolean runAsync, Long queryTimeout) {
public StatementRequest(
String statement, boolean runAsync, Long queryTimeout, Map<String, String> confOverlay) {
this.statement = statement;
this.runAsync = runAsync;
this.queryTimeout = queryTimeout;
this.confOverlay = confOverlay;
}

public String getStatement() {
Expand All @@ -58,6 +63,17 @@ public void setQueryTimeout(Long queryTimeout) {
this.queryTimeout = queryTimeout;
}

public Map<String, String> getConfOverlay() {
if (confOverlay == null) {
return Collections.emptyMap();
}
return confOverlay;
}

public void setConfOverlay(Map<String, String> confOverlay) {
this.confOverlay = confOverlay;
}

@Override
public boolean equals(Object o) {
if (this == o) return true;
Expand Down
2 changes: 1 addition & 1 deletion kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/SessionsResource.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ private[v1] class SessionsResource extends ApiRequestContext with Logging {
fe.be.executeStatement(
sessionHandleStr,
request.getStatement,
Map.empty,
request.getConfOverlay.asScala,
request.isRunAsync,
request.getQueryTimeout)
} catch {
Expand Down