Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to specify confOverlay when executing statement with RESTful API #4639

Closed
wants to merge 5 commits into from

Conversation

turboFei
Copy link
Member

@turboFei turboFei commented Mar 30, 2023

Why are the changes needed?

As title.

With this pr, customer can execute SCALA code with confOverlay.

kyuubi.operation.language=SCALA

execute PYTHON code with

kyuubi.operation.language=PYTHON

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@yaooqinn
Copy link
Member

can we add a test?

@turboFei
Copy link
Member Author

turboFei commented Mar 30, 2023

can we add a test?

WIP

@github-actions github-actions bot added the kind:documentation Documentation is a feature! label Mar 30, 2023
@turboFei turboFei self-assigned this Mar 30, 2023
@turboFei turboFei added this to the v1.7.1 milestone Mar 30, 2023
@turboFei turboFei closed this in 0fdf145 Mar 30, 2023
turboFei added a commit that referenced this pull request Mar 30, 2023
…t with RESTful API

### _Why are the changes needed?_

As title.

With this pr, customer can execute SCALA code with `confOverlay`.
```
kyuubi.operation.language=SCALA
```
execute PYTHON code with
```
kyuubi.operation.language=PYTHON
```
### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #4639 from turboFei/init_scala.

Closes #4639

cdf828f [fwang12] add ut
f4f2bc8 [fwang12] doc
2fe8a16 [fwang12] save
f840cb4 [fwang12] conf overlay
eb49537 [fwang12] conf overlay

Authored-by: fwang12 <[email protected]>
Signed-off-by: fwang12 <[email protected]>
(cherry picked from commit 0fdf145)
Signed-off-by: fwang12 <[email protected]>
@turboFei turboFei deleted the init_scala branch March 30, 2023 11:14
@turboFei
Copy link
Member Author

thanks, merged to master and 1.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants