[UI][CI] Fix Web UI Ci check fail with pnpm the lockfile needs updates #4626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
module:server
kind:infra
pan3793
reviewed
Mar 28, 2023
pan3793
reviewed
Mar 28, 2023
pan3793
added a commit
that referenced
this pull request
Mar 28, 2023
…le needs updates ### _Why are the changes needed?_ After pnpm released 8.X version We should specify pnpm version when npm install. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request - [x] CI with Web UI Build Check & Web UI Style Check Closes #4626 from zwangsheng/fix/web_ui_ci. Closes #4626 f7fdc06 [Cheng Pan] Update .github/workflows/web-ui.yml 61bc101 [Cheng Pan] Update .github/workflows/style.yml 7d93532 [zwangsheng] Specify pnpm version d678c6c [zwangsheng] for feature version 6d83c2b [zwangsheng] revert bbc4b4c [zwangsheng] Specify pnpm version Lead-authored-by: zwangsheng <[email protected]> Co-authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 6a7c571) Signed-off-by: Cheng Pan <[email protected]>
|
Thanks, merged to master/1.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
After pnpm released 8.X version
We should specify pnpm version when npm install.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
CI with Web UI Build Check & Web UI Style Check