Skip to content

Commit

Permalink
[KYUUBI #4626] [UI][CI] Fix Web UI Ci check fail with pnpm the lockfi…
Browse files Browse the repository at this point in the history
…le needs updates

### _Why are the changes needed?_

After pnpm released 8.X version

We should specify pnpm version when npm install.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
- [x] CI with Web UI Build Check & Web UI Style Check

Closes #4626 from zwangsheng/fix/web_ui_ci.

Closes #4626

f7fdc06 [Cheng Pan] Update .github/workflows/web-ui.yml
61bc101 [Cheng Pan] Update .github/workflows/style.yml
7d93532 [zwangsheng] Specify pnpm version
d678c6c [zwangsheng] for feature version
6d83c2b [zwangsheng] revert
bbc4b4c [zwangsheng] Specify pnpm version

Lead-authored-by: zwangsheng <[email protected]>
Co-authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit 6a7c571)
Signed-off-by: Cheng Pan <[email protected]>
  • Loading branch information
zwangsheng and pan3793 committed Mar 28, 2023
1 parent 4432565 commit 837073d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/style.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ jobs:
- name: Web UI Style with node
run: |
cd ./kyuubi-server/web-ui
npm install pnpm -g
npm install pnpm@7 -g
pnpm install
pnpm run lint
echo "---------------------------------------Notice------------------------------------"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/web-ui.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: npm run coverage & build
run: |
cd ./kyuubi-server/web-ui
npm install pnpm -g
npm install pnpm@7 -g
pnpm install
pnpm run coverage
pnpm run build

0 comments on commit 837073d

Please sign in to comment.