Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #2159][FLINK] Prevent loss of exception message line separator #2161

Closed
wants to merge 3 commits into from

Conversation

a49a
Copy link
Contributor

@a49a a49a commented Mar 17, 2022

Why are the changes needed?

Flink SQL Exception message loses line separator.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@pan3793
Copy link
Member

pan3793 commented Mar 17, 2022

Except for this one, are there other properties that look unreasonable?

@a49a
Copy link
Contributor Author

a49a commented Mar 18, 2022

I have introduced the white list to filter args.

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2022

Codecov Report

Merging #2161 (15e311d) into master (36507f8) will increase coverage by 0.15%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #2161      +/-   ##
============================================
+ Coverage     61.27%   61.43%   +0.15%     
- Complexity      114      117       +3     
============================================
  Files           320      323       +3     
  Lines         15501    15591      +90     
  Branches       1992     2001       +9     
============================================
+ Hits           9498     9578      +80     
  Misses         5193     5193              
- Partials        810      820      +10     
Impacted Files Coverage Δ
...ache/kyuubi/engine/flink/FlinkProcessBuilder.scala 71.95% <0.00%> (-2.74%) ⬇️
...ache/kyuubi/operation/KyuubiOperationManager.scala 92.50% <0.00%> (-2.50%) ⬇️
...mon/src/main/scala/org/apache/kyuubi/Logging.scala 39.72% <0.00%> (-1.37%) ⬇️
...org/apache/spark/kyuubi/SQLOperationListener.scala 94.11% <0.00%> (ø)
...pache/kyuubi/engine/hive/operation/GetTables.scala 100.00% <0.00%> (ø)
.../apache/spark/kyuubi/SparkConsoleProgressBar.scala 94.00% <0.00%> (ø)
...in/scala/org/apache/spark/kyuubi/StageStatus.scala 66.66% <0.00%> (ø)
.../kyuubi/credentials/HadoopCredentialsManager.scala 95.65% <0.00%> (+0.15%) ⬆️
...i/engine/hive/operation/HiveOperationManager.scala 30.00% <0.00%> (+5.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36507f8...15e311d. Read the comment docs.

@yaooqinn yaooqinn closed this in 4eb5df3 Mar 19, 2022
@yaooqinn yaooqinn added this to the v1.6.0 milestone Mar 19, 2022
@yaooqinn
Copy link
Member

thanks, merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants