-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYUUBI #2159][FLINK] Prevent loss of exception message line separator #2161
Conversation
Except for this one, are there other properties that look unreasonable? |
I have introduced the white list to filter args. |
Codecov Report
@@ Coverage Diff @@
## master #2161 +/- ##
============================================
+ Coverage 61.27% 61.43% +0.15%
- Complexity 114 117 +3
============================================
Files 320 323 +3
Lines 15501 15591 +90
Branches 1992 2001 +9
============================================
+ Hits 9498 9578 +80
Misses 5193 5193
- Partials 810 820 +10
Continue to review full report at Codecov.
|
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/flink/FlinkProcessBuilder.scala
Outdated
Show resolved
Hide resolved
thanks, merged to master |
Why are the changes needed?
Flink SQL Exception message loses line separator.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request