Skip to content

Commit

Permalink
[KYUUBI #2159][FLINK] Prevent loss of exception message line separator
Browse files Browse the repository at this point in the history
### _Why are the changes needed?_

Flink SQL Exception message loses line separator.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #2161 from deadwind4/KYUUBI-2159-newline.

Closes #2159

15e311d [Ada Wong] use filter
419b44e [Ada Wong] Use white list to filter
5cd80eb [Ada Wong] [KYUUBI #2159][FLINK] Prevent loss of exception message line separator

Authored-by: Ada Wong <[email protected]>
Signed-off-by: Kent Yao <[email protected]>
  • Loading branch information
a49a authored and yaooqinn committed Mar 19, 2022
1 parent 2911ac2 commit 4eb5df3
Showing 1 changed file with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,10 @@ class FlinkProcessBuilder(
("FLINK_CONF_DIR" -> s"$FLINK_HOME/conf") +
("FLINK_SQL_ENGINE_JAR" -> mainResource.get) +
("FLINK_SQL_ENGINE_DYNAMIC_ARGS" ->
conf.getAll.map { case (k, v) => s"-D$k=$v" }.mkString(" "))
conf.getAll.filter { case (k, _) =>
k.startsWith("kyuubi.") || k.startsWith("flink.") ||
k.startsWith("hadoop.") || k.startsWith("yarn.")
}.map { case (k, v) => s"-D$k=$v" }.mkString(" "))

override protected def commands: Array[String] = Array(executable)

Expand Down

0 comments on commit 4eb5df3

Please sign in to comment.