-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flink backend implementation #1629
Conversation
...ls/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/FetchIterator.scala
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1629 +/- ##
============================================
+ Coverage 58.23% 59.08% +0.85%
- Complexity 164 193 +29
============================================
Files 258 264 +6
Lines 12803 13079 +276
Branches 1608 1650 +42
============================================
+ Hits 7456 7728 +272
+ Misses 4717 4696 -21
- Partials 630 655 +25
Continue to review full report at Codecov.
|
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/flink/FlinkEngineProcessBuilder.scala
Outdated
Show resolved
Hide resolved
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/flink/FlinkEngineProcessBuilder.scala
Outdated
Show resolved
Hide resolved
build/dist
Outdated
SUFFIX="" | ||
else | ||
SUFFIX="-spark-${SPARK_VERSION:0:3}-hadoop${SPARK_HADOOP_VERSION}" | ||
if [[ "$NAME" != "none" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build/dist --tgz --flink-provided --spark-provided
=> apache-kyuubi-1.5.0-SNAPSHOT-bin.tgz
build/dist --tgz --name custom
=> apache-kyuubi-1.5.0-SNAPSHOT-bin-custom.tgz
build/dist --tgz --spark-provided
=> apache-kyuubi-1.5.0-SNAPSHOT-bin-flink-1.14.tgz
build/dist --tgz --flink-provided
=> apache-kyuubi-1.5.0-SNAPSHOT-spark-3.1-hadoop3.2.tgz
build/dist --tgz
=> apache-kyuubi-1.5.0-SNAPSHOT-bin-flink-1.14-spark-3.1-hadoop3.2.tgz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this name pattern looks good?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently, I am fine with the naming. But, if we introduce trino/presto, the name would be very long.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not good, we have a release file already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not good, we have a release file already
We only have one apache official release binary tarball apache-kyuubi-{VERSION}-bin.tgz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's leave it as-is, we don't change the naming policy with a new engine added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted
...uubi-flink-sql-engine/src/test/scala/org/apache/kyuubi/engine/flink/WithFlinkSQLEngine.scala
Outdated
Show resolved
Hide resolved
...s/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/FlinkSQLEngine.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks, merged to master |
Why are the changes needed?
This PR covers #1619.
Overall, this PR contains the following changs,
build/dist
script to support flink sql engineexternals/flink-sql-engine/pom.xml
to support create a shaded jarexternals/kyuubi-flink-sql-engine/bin/flink-sql-engine.sh
FlinkSQLEngine
(flink sql engine entrypoint) andFlinkProcessBuilder
(kyuubi server launcher)After this PR, we can run the basic query e.g.
select now()
from beeline and get result, and Kyuubi Server can auto launch flink engine if there is no proper one. The Flink engine also supports other engine share levels defined in Kyuubi.The implementation based on Flink 1.14 codebase.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request