[WIP][KYUUBI #1352] Introduce FlinkSQLEngine infrastructure #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
reviewed
Nov 10, 2021
pan3793
reviewed
Nov 10, 2021
|
Awesome~ |
yanghua
changed the title
pan3793
reviewed
Nov 11, 2021
pan3793
reviewed
Nov 11, 2021
...uubi-flink-sql-engine/src/test/scala/org/apache/kyuubi/engine/flink/WithFlinkSQLEngine.scala
Outdated
Show resolved
Hide resolved
...ql-engine/src/main/scala/org/apache/kyuubi/engine/flink/session/FlinkSQLSessionManager.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Nov 11, 2021
| statement: String, | ||
| runAsync: Boolean, | ||
| queryTimeout: Long): Operation = { | ||
| null |
There was a problem hiding this comment.
All of operations are stub now?
pan3793
reviewed
Nov 11, 2021
...ql-engine/src/main/scala/org/apache/kyuubi/engine/flink/session/FlinkSQLSessionManager.scala
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1357 +/- ##
============================================
- Coverage 59.38% 56.34% -3.04%
- Complexity 172 380 +208
============================================
Files 237 288 +51
Lines 12168 13727 +1559
Branches 1492 1551 +59
============================================
+ Hits 7226 7735 +509
- Misses 4331 5358 +1027
- Partials 611 634 +23
Continue to review full report at Codecov.
|
yanghua
force-pushed
the
KYUUBI-1352
branch
9 times, most recently
from
7df07a5 to
3e33762
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request