This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[WEEX-581][android] fix 'onFocus invoked twice #1460
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix @Focus invoked twice
Generated by 🚫 dangerJS |
gubaojian
reviewed
Nov 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good bugfix, thanks you
Please rebase your commit, there is a conflict. @chenzefeng09 |
conflict resolved @YorkShen @gubaojian |
@gubaojian Need your approval, thanks |
YorkShen
suggested changes
Jan 8, 2019
android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java
Outdated
Show resolved
Hide resolved
YorkShen
approved these changes
Jan 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when label has both '@Focus' & '@blur' method, both methods will be invoked twice when trigger focus/blur event