Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[WEEX-581][android] fix 'onFocus invoked twice #1460

Merged
merged 6 commits into from
Jan 9, 2019
Merged

[WEEX-581][android] fix 'onFocus invoked twice #1460

merged 6 commits into from
Jan 9, 2019

Conversation

chenzefeng09
Copy link
Contributor

when label has both '@Focus' & '@blur' method, both methods will be invoked twice when trigger focus/blur event

when set @foucus & @blur method to <input> ,@Focus will be called twice when <input> is focused
@weex-bot
Copy link

weex-bot commented Aug 22, 2018

Fails
🚫 Failed to run assembleDebug task for android.
Messages
📖 android build verification finished.

Generated by 🚫 dangerJS

@chenzefeng09 chenzefeng09 changed the title [android] fix 'onFocus invoked twice [WEEX-581][android] fix 'onFocus invoked twice Aug 22, 2018
Copy link
Member

@gubaojian gubaojian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good bugfix, thanks you

@YorkShen
Copy link
Contributor

YorkShen commented Dec 6, 2018

Please rebase your commit, there is a conflict. @chenzefeng09

@chenzefeng09
Copy link
Contributor Author

chenzefeng09 commented Dec 6, 2018

conflict resolved @YorkShen @gubaojian

@YorkShen
Copy link
Contributor

@gubaojian Need your approval, thanks

Copy link
Contributor

@YorkShen YorkShen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YorkShen YorkShen merged commit cd8c6c7 into apache:master Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants