This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
[WEEX-17] Abstract a common weex var for each JS framework #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jinjiang
changed the title
|
Just FYI, usually one commit per pull request[1] is recommended. Once it synced with apache git, you can't change or clean up commit histories. |
asfgit
pushed a commit
that referenced
this pull request
Apr 10, 2017
add the component type, when the node is virtual node
asfgit
pushed a commit
that referenced
this pull request
Sep 26, 2017
* [html5] add _triggered on event when evtName is click
This was referenced Jan 23, 2018
gubaojian
pushed a commit
that referenced
this pull request
Nov 27, 2018
* [android] Support richtext component (#1796)
YorkShen
pushed a commit
that referenced
this pull request
Dec 3, 2018
Fix following crash
> signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 57286b7f
r0 89a8e0c0 r1 ff86f5ec r2 89a8e0c0 r3 57286b63
r4 89a8e0c0 r5 12e23560 r6 c3298dcc r7 6fba3af4
r8 147c9780 r9 eb505400 10 00000000 fp 00000000
ip a6af6dbc sp ff86f5c8 lr a6a5ec5f pc a6a1d4ec cpsr 800f0030
#00 pc 0x7d4ec libweexcore.so (_ZN8WeexCore16WXCoreLayoutNode30getLayoutDirectionFromPathNodeEv+5)
#1 pc 0xbec5b libweexcore.so
#2 pc 0xb751ed base.odex
Closed
This was referenced Jan 7, 2019
jianhan-he
pushed a commit
that referenced
this pull request
Aug 16, 2019
The return value of `jString2StrFast(env, instanceId)` could be `std::string(nullptr)`` if instanceId is `nullptr`, in which case the return value would cause crash.
```
#00 pc 0x4aaec libweexcore.so (_ZNSt6__ndk16__treeINS_12__value_typeINS_12basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEEEPN8WeexCore14RenderPageBaseEEENS_19__map_value_compareIS7_SB_NS_4lessIS7_EELb1EEENS5_ISB_EEE13__lower_boundIS7_EENS_15__tree_iteratorISB_PNS_11__tree_nodeISB_PvEEiEERKT_SN_PNS_15__tree_end_nodeIPNS_16__tree_node_baseISL_EEEE+23)
#1 pc 0x4aa6b libweexcore.so (_ZNSt6__ndk16__treeINS_12__value_typeINS_12basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEEEPN8WeexCore14RenderPageBaseEEENS_19__map_value_compareIS7_SB_NS_4lessIS7_EELb1EEENS5_ISB_EEE4findIS7_EENS_15__tree_iteratorISB_PNS_11__tree_nodeISB_PvEEiEERKT_+18)
#2 pc 0x4907b libweexcore.so (_ZN8WeexCore13RenderManager7GetPageERKNSt6__ndk112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEE+6)
#3 pc 0x5d2d5 libweexcore.so (_ZN8WeexCore18CoreSideInPlatform12NotifyLayoutERKNSt6__ndk112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEE+12)
```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accepted weex variable from JS runtime before
legacyFramework.createInstance.