Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle empty primary key correctly #1805

Merged
merged 1 commit into from
May 7, 2022
Merged

fix: handle empty primary key correctly #1805

merged 1 commit into from
May 7, 2022

Conversation

mindlesscloud
Copy link
Contributor

Summary

fix #1799
handle empty primary key correctly

Key Points

  • This is a breaking change
  • New or existing documentation is updated

Description

Describe what this PR does, and aims to solve in a few sentences.

Does this close any open issues?

close #1799

Screenshots

image

Other Information

Any other information that is important to this PR.

Copy link
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klesh klesh merged commit 2d93add into main May 7, 2022
@klesh klesh deleted the fix#1799 branch May 7, 2022 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

batch save deduplication has bug which causes some domain layers have only one piece of data
2 participants