Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

batch save deduplication has bug which causes some domain layers have only one piece of data #1799

Closed
abeizn opened this issue May 6, 2022 · 0 comments · Fixed by #1805
Closed

batch save deduplication has bug which causes some domain layers have only one piece of data #1799

abeizn opened this issue May 6, 2022 · 0 comments · Fixed by #1805
Assignees
@mindlesscloud
Labels
priority/high This issue is very important type/bug This issue is a bug
Milestone
v0.11.0

Comments

@abeizn
Copy link
Contributor

abeizn commented May 6, 2022 •
edited
Loading

Describe the bug

batch save deduplication has bug, so domian layer issue/comments have only one piece of data. maybe getPrimaryKeyValue function has logic error.

To Reproduce

Steps to reproduce the behavior:

  1. run lake repo（default）
  2. domian layer issue/comments have only one piece of data.

Expected behavior

The domain layer has only one piece of data.

Screenshots

image

image

Additional context

Add any other context about the problem here.
@abeizn abeizn added the type/bug This issue is a bug label May 6, 2022
@abeizn abeizn added this to the v0.11.0 milestone May 6, 2022
@Startrekzky Startrekzky added the priority/high This issue is very important label May 6, 2022
@abeizn abeizn changed the title batch save deduplication has bug batch save deduplication has bug which causes some domain layers have only one piece of data May 6, 2022
@mindlesscloud mindlesscloud mentioned this issue May 6, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mindlesscloud mindlesscloud

Labels
priority/high This issue is very important type/bug This issue is a bug
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging a pull request may close this issue.

fix: handle empty primary key correctly apache/incubator-devlake
3 participants
@mindlesscloud @Startrekzky @abeizn