Fix CI script inclusion of release branches #10514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CI scripts are meant to run on release maintenance branches such as 1.5.x. They were run for releases up to 1.0 because of the `0.*` pattern This commit: - includes `1.*` branches (but that's likely needs to be propagated to existing branches) - includes `2.*` branches foreseeing imminent 2.0 release - changes the `0.**` pattern to `0.*`. Multiple asterisks are needed to match branch names including `/` but release branche naming convention do not expect such branch names.
|
@nastra @Fokko @rdblue |
|
Draft -- would prefer #10515 . |
|
undraft per #10515 (comment) |
nastra
approved these changes
Jun 28, 2024
This was referenced Jun 28, 2024
findepi
deleted the
findepi/fix-ci-script-inclusion-of-release-branches-aa1424
branch
jasonf20
pushed a commit
to jasonf20/iceberg
that referenced
this pull request
Aug 4, 2024
The CI scripts are meant to run on release maintenance branches such as 1.5.x. They were run for releases up to 1.0 because of the `0.*` pattern This commit: - includes `1.*` branches (but that's likely needs to be propagated to existing branches) - includes `2.*` branches foreseeing imminent 2.0 release - changes the `0.**` pattern to `0.*`. Multiple asterisks are needed to match branch names including `/` but release branche naming convention do not expect such branch names.
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
The CI scripts are meant to run on release maintenance branches such as 1.5.x. They were run for releases up to 1.0 because of the `0.*` pattern This commit: - includes `1.*` branches (but that's likely needs to be propagated to existing branches) - includes `2.*` branches foreseeing imminent 2.0 release - changes the `0.**` pattern to `0.*`. Multiple asterisks are needed to match branch names including `/` but release branche naming convention do not expect such branch names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI scripts are meant to run on release maintenance branches such as 1.5.x. They were run for releases up to 1.0 because of the
0.*patternThis commit:
1.*branches (but that's likely needs to be propagated to existing branches)2.*branches foreseeing imminent 2.0 release0.**pattern to0.*. Multiple asterisks are needed to match branch names including/but release branche naming convention do not expect such branch names.