fix(geo): label formatter in geo works incorrectly, tweaks #10666 & #8612. #12762
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Because of the change about the structure of normal style and emphasis style, original logic about fetching formatter of label has been not suitable. There are some changes to be done.
Original way to fetch label formatter:
normal:
label.formatter
(It's okay now)emphasis:
label.emphasis.formatter
(in #10666, a dot is also missing, but even if we add it, it is still not correct for present option structure).Present way to fetch label formatter:
normal:
label.formatter
(same as original way)emphasis:
emphasis.label.formatter
(Seegeo.emphasis.label.formatter
).Fixed issues
Details
Before: What was the problem?
geo.label.formatter
is not working.After: How is it fixed in this PR?
Using the way suitable for current option structure.
Usage
Are there any API changes?
Related test cases or examples to use the new APIs
Please refer to
test/geo-labelFormatter.html
.Others
Merging options