Skip to content

Commit

Permalink
Merge pull request #12762 from plainheart/fix-geo-label-formatter
Browse files Browse the repository at this point in the history
fix(geo): label formatter in geo works incorrectly, tweaks #10666 & #8612.
  • Loading branch information
pissang authored Jun 22, 2020
2 parents 5c1a5fb + 940b872 commit 300f75d
Show file tree
Hide file tree
Showing 2 changed files with 367 additions and 6 deletions.
9 changes: 3 additions & 6 deletions src/coord/geo/GeoModel.js
Original file line number Diff line number Diff line change
Expand Up @@ -147,12 +147,9 @@ var GeoModel = ComponentModel.extend({
* @return {string}
*/
getFormattedLabel: function (name, status) {
status = status || 'normal';
var regionModel = this.getRegionModel(name);
var formatter = regionModel.get(
'label'
+ (status === 'normal' ? '.' : status + '.')
+ 'formatter'
);
var formatter = regionModel.get((status === 'normal' ? '' : status + '.') + 'label.formatter');
var params = {
name: name
};
Expand All @@ -176,4 +173,4 @@ var GeoModel = ComponentModel.extend({

zrUtil.mixin(GeoModel, selectableMixin);

export default GeoModel;
export default GeoModel;
Loading

0 comments on commit 300f75d

Please sign in to comment.