Minor: rename GetFieldAccessCharacteristic and add docs
#7220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
|
CI is failing due to #7221 |
yjshen
approved these changes
Aug 8, 2023
izveigor
reviewed
Aug 8, 2023
datafusion/expr/src/field_util.rs
Outdated
| /// # Error | ||
| /// Errors if | ||
| /// * the `data_type` is not a Struct or a List, | ||
| /// * the `data_type` of extra key does not match with `data_type` of key |
There was a problem hiding this comment.
It is better to replace extra_key and key with new terms
There was a problem hiding this comment.
I updated this in c97313f -- what do you think?
izveigor
approved these changes
Aug 8, 2023
alamb
commented
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #7193
Follows #7215 from @izveigor
Rationale for this change
In order to have a good experience accessing fields, it should be easy to use the code that manipulates them
What changes are included in this PR?
GetFieldAccessCharacteristictoGetFieldAccessSchemato better reflect what it doesGetFieldAccessSchema::get_accessed_fieldAre these changes tested?
Covered by existing tests
Are there any user-facing changes?
No, these are unreleased APIs (added in #7215)