Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve the ergonomics of creating field and list array accesses #7215

Merged
merged 3 commits into from
Aug 7, 2023
Merged

improve the ergonomics of creating field and list array accesses #7215

merged 3 commits into from
Aug 7, 2023

Conversation

izveigor
Copy link
Contributor

@izveigor izveigor commented Aug 7, 2023

Which issue does this PR close?

Closes #7193
Closes #7146

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Yes

Are there any user-facing changes?

Yes

@izveigor izveigor marked this pull request as draft August 7, 2023 11:56
@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates core Core DataFusion crate labels Aug 7, 2023
@izveigor izveigor mentioned this pull request Aug 7, 2023
Closed
2 tasks
@izveigor
Copy link
Contributor Author

izveigor commented Aug 7, 2023

@alamb @jayzhan211 I wonder if you have free time to review this PR.

@alamb
Copy link
Contributor

alamb commented Aug 7, 2023

Thanks @izveigor -- I am checking this one out now

@izveigor izveigor marked this pull request as ready for review August 7, 2023 14:47
@alamb alamb added the api change Changes the API exposed to users of the crate label Aug 7, 2023
alamb
alamb approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great @izveigor ! Thank you very much.

While reviewing this PR I had some ideas about how to make it even easier to use and some comments to add, but I will propose a follow on PR to do so.

🙏

datafusion/physical-expr/src/expressions/get_indexed_field.rs
list_key: Option<Arc<dyn PhysicalExpr>>,
/// The key expression for `DataType::Struct`
struct_key: Option<ScalarValue>,
pub enum GetFieldAccessExpr {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb alamb merged commit b6c4fed into apache:main Aug 7, 2023
This was referenced Aug 7, 2023
Merged
Merged
@Weijun-H Weijun-H mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
api change Changes the API exposed to users of the crate core Core DataFusion crate logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates sql SQL Planner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the ergonomics of creating field and list array accesses Improve GetIndexedField in protobuf
2 participants
@izveigor @alamb