Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: Remove mac m1 compilation for size_of_scalar test #7151

Merged
merged 3 commits into from
Aug 1, 2023
Merged

minor: Remove mac m1 compilation for size_of_scalar test #7151

merged 3 commits into from
Aug 1, 2023

Conversation

mustafasrepo
Copy link
Contributor

Which issue does this PR close?

Closes #7089.

Rationale for this change

size_of_scalar test seems to be failing in M1 machines. This PR removes this test when target architecture is arm64.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@jackwener jackwener changed the title [minor]: Remove mac m1 compilation for size_of_scalar test minor: Remove mac m1 compilation for size_of_scalar test Aug 1, 2023
@jackwener jackwener merged commit 82a809b into apache:main Aug 1, 2023
@mustafasrepo mustafasrepo deleted the bug_fix/size_scalr_test_m1 branch August 2, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

size_of_scalar test fails in main branch
3 participants