Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

size_of_scalar test fails in main branch #7089

Closed
mustafasrepo opened this issue Jul 25, 2023 · 4 comments · Fixed by #7151
Closed

size_of_scalar test fails in main branch #7089

mustafasrepo opened this issue Jul 25, 2023 · 4 comments · Fixed by #7151
Labels
bug Something isn't working

Comments

@mustafasrepo
Copy link
Contributor

Describe the bug

size_of_scalar test fails in the main branch.

assert_eq!(std::mem::size_of::<ScalarValue>(), 48);

the result is 64. I am not sure which should be the case.

To Reproduce

No response

Expected behavior

No response

Additional context

No response

@mustafasrepo mustafasrepo added the bug Something isn't working label Jul 25, 2023
@alamb
Copy link
Contributor

alamb commented Jul 30, 2023

This doesn't happen for me. How can we reproduce it?

https://github.com/apache/arrow-datafusion/blob/01d7dbaf392b4a217e1a27c96bbcd1126b763828/datafusion/common/src/scalar.rs#L4637-L4646

Maybe it is related to architecture?

@mustafasrepo
Copy link
Contributor Author

This doesn't happen for me. How can we reproduce it?

https://github.com/apache/arrow-datafusion/blob/01d7dbaf392b4a217e1a27c96bbcd1126b763828/datafusion/common/src/scalar.rs#L4637-L4646

Maybe it is related to architecture?

It seems so, also in CI there is no problem. I use Macbook M1-Ventura 13.3.1

@alamb
Copy link
Contributor

alamb commented Jul 31, 2023

Maybe we should just conditionalize the test (like #cfg(...)) for architectures where the size is different -- I thought I remember this test having a aarch variant that asserted the size was 64 for some reason

@mustafasrepo
Copy link
Contributor Author

I will do so, thanks @alamb .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants