Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEANUTILS-541] FluentPropertyBeanIntrospector caches corrupted writeMethod (1.x backport) #69

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

seregamorph
Copy link
Contributor

@seregamorph seregamorph changed the title BEANUTILS-541 - FluentPropertyBeanIntrospector caches corrupted writeMethod BEANUTILS-541 - FluentPropertyBeanIntrospector caches corrupted writeMethod (1.x) Jan 10, 2021
@seregamorph
Copy link
Contributor Author

@garydgregory I see that you have some activity in this project. WDYT finally review real issues with value? I mean these two:

Current implementation has a severe issue. If you think this project does not deserve meaningful changes, please let me know so I would not waste time on these efforts.

@garydgregory
Copy link
Member

garydgregory commented Apr 14, 2024

Hello @seregamorph
Thank you for the reminder, please rebase on git 1.X to pick up the new GH workflow.

@seregamorph seregamorph force-pushed the bugfix/BEANUTILS-541-backport branch from a66f692 to b567d07 Compare April 14, 2024 09:09
@seregamorph
Copy link
Contributor Author

The branch is rebased. Please note this this change is just a backport of
#68

@seregamorph seregamorph changed the title BEANUTILS-541 - FluentPropertyBeanIntrospector caches corrupted writeMethod (1.x) BEANUTILS-541 - FluentPropertyBeanIntrospector caches corrupted writeMethod (1.x backport) Apr 14, 2024
@garydgregory garydgregory merged commit 8ac9a64 into apache:1.X Apr 14, 2024
2 checks passed
@garydgregory garydgregory changed the title BEANUTILS-541 - FluentPropertyBeanIntrospector caches corrupted writeMethod (1.x backport) [BEANUTILS-541] FluentPropertyBeanIntrospector caches corrupted writeMethod (1.x backport) Apr 14, 2024
asfgit pushed a commit that referenced this pull request Apr 14, 2024
@basil
Copy link

basil commented Jan 8, 2025

@seregamorph #68 was merged to the master branch but apparently introduced a concurrency issue which was fixed in #234 on the master branch. #69 (a backport of #68) was then merged to the 1.X branch, but no backport of #234 was ever merged to the 1.X branch. 1.10.0 was then released from the 1.X line. Does this mean that the 1.10.0 release is subject to the concurrency issue that was fixed in #234 on the master branch?

@seregamorph
Copy link
Contributor Author

@basil it seems that I've forgotten to backport the concurrency fix to 1.x. It means that we need a hotfix for 1.10.0 cherry-picking #234

@seregamorph seregamorph deleted the bugfix/BEANUTILS-541-backport branch January 8, 2025 20:01
@garydgregory
Copy link
Member

Hello @seregamorph
Feel free to create a PR and I can cut another release candidate later this week or next. Cherry-picking won't work since the package names are different.
TY!

@seregamorph
Copy link
Contributor Author

@garydgregory #325
@basil thanks for finding this (and apologies for my mistake), also please take a look at the fix (and verify if you have opportunity)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants