Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEANUTILS-541] FluentPropertyBeanIntrospector concurrency issue (backport to 1.X) #325

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

seregamorph
Copy link
Contributor

@seregamorph seregamorph commented Jan 8, 2025

Fix concurrency issue introduced in #69
Backport from master of #234

https://issues.apache.org/jira/browse/BEANUTILS-541

@seregamorph seregamorph force-pushed the backport-concurrency branch from 88c9331 to 554baea Compare January 8, 2025 21:17
@seregamorph
Copy link
Contributor Author

Fixed checkstyle violation (imports order)

@garydgregory garydgregory merged commit b9b280c into apache:1.X Jan 8, 2025
7 checks passed
@garydgregory garydgregory changed the title BEANUTILS-541 - FluentPropertyBeanIntrospector concurrency issue (backport 1.X) BEANUTILS-541 - FluentPropertyBeanIntrospector concurrency issue (backport to 1.X) Jan 8, 2025
@garydgregory garydgregory changed the title BEANUTILS-541 - FluentPropertyBeanIntrospector concurrency issue (backport to 1.X) [BEANUTILS-541] FluentPropertyBeanIntrospector concurrency issue (backport to 1.X) Jan 8, 2025
asfgit pushed a commit that referenced this pull request Jan 9, 2025
@seregamorph
Copy link
Contributor Author

@garydgregory any plans to release this soon? I believe, concurrency issue is a good reason :)

@garydgregory
Copy link
Member

garydgregory commented Jan 14, 2025

It was just released last week. What am I missing?

Oh, I see, a maintenance release. Not sure, I have a couple of other tasks on my todo list. I'll put it on the to do list.

@qotkin
Copy link

qotkin commented Jan 26, 2025

We faced similar problem in our project, waiting for the 1.10.1 hotfix to be released.
Also as I can see other PRs are referencing this issue, e.g. this jenkinsci/jenkins#10127

@garydgregory
Copy link
Member

Hello @qotkin
Did you test the snapshot build or a local build?

@qotkin
Copy link

qotkin commented Jan 27, 2025

We deployed snapshot (built from 1.X branch) to our local nexus repository and performance engineer checked it on perf-environment (via high load test client). They confirmed that problem was reproducible with 1.10.0, but does not happen anymore on the snapshot (which includes fix of this PR). According to our policies we cannot release on prod the snapshot version, so waiting for official 1.10.1

@seregamorph seregamorph deleted the backport-concurrency branch January 30, 2025 18:09
@seregamorph
Copy link
Contributor Author

@garydgregory out of curiosity, are there reasons why you postpone the release?
IMO this makes a lot of sense to release, as dependabot is advertising this version with concurrency issue . Maybe you need more inputs explaining what's exact problem (I tried to explain this in the description of #234 )

@garydgregory
Copy link
Member

Yes, the reason is: "I'm busy". This component's 1.10.1 will be next, probably within the next few days, you'll have a release candidate to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants