[refactor] [server] Refactor ByteBuf release method in module distributedlog-core/distributedlog-protocol #3693
+18
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenLuMT
force-pushed
the
master_safeRelease_distributedlog-common/protocol
branch
from
e757255 to
b2fc2d9
Compare
StevenLuMT
requested review from
dlg99,
eolivelli,
hangc0276 and
nicoloboschi
9 tasks
|
@StevenLuMT Please do not tag |
hangc0276
approved these changes
Dec 7, 2022
Got it ,thanks @hangc0276 |
hangc0276
pushed a commit
that referenced
this pull request
Dec 8, 2022
…f release usage (#3693) Co-authored-by: lushiji <[email protected]> (cherry picked from commit a71c7a7)
hangc0276
added
release/4.14.6
cherry-picked/branch-4.14
and removed
release/4.14.7
labels
nicoloboschi
pushed a commit
to datastax/bookkeeper
that referenced
this pull request
Jan 11, 2023
…f release usage (apache#3693) Co-authored-by: lushiji <[email protected]> (cherry picked from commit a71c7a7) (cherry picked from commit 8e352d4)
yaalsn
pushed a commit
to yaalsn/bookkeeper
that referenced
this pull request
Jan 30, 2023
…f release usage (apache#3693) Co-authored-by: lushiji <[email protected]>
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…f release usage (apache#3693) Co-authored-by: lushiji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It may throw an exception when release a ByteBuf object. so the exception in ByteBuf.release should be checked.
Changes