BP-61: Revert BP-59 to release ByteBuf using ReferenceCountUtil.release() instead of ReferenceCountUtil.safeRelease()

[hangc0276]

BP

Follow the instructions at https://bookkeeper.apache.org/community/bookkeeper-proposals/ to create a proposal.

This is the master ticket for tracking BP-61 :

Motivation

In BP-59, which was not discussed in the dev mail list and without a vote refactored the ByteBuf release method by ReferenceCountUtil.safeRelease() instead of ByteBuf.release().

In the ReferenceCountUtil.safeRelease(), it catches the release exception. This change can make the ByteBuf release without any exceptions and makes the code run well, but it will make bugs hide deeper and more challenging to find out.

public static void safeRelease(Object msg) {
     try {
         release(msg);
     } catch (Throwable t) {
         logger.warn("Failed to release a message: {}", msg, t);
     }
 }

For example, if there is a bug to release the ByteBuf twice, whose refcnt is 1, we can find out the bug quickly if we use ByteBuf.release(), but the bug will be hard to find out if we use ReferenceCountUtil.safeRelease()

There are 12 PRs to refactor the ByteBuf release method, and I suggest reverting those PRs.

• [refactor][bookkeeper] Refactor ByteBuf release method in DefaultEntryLogger #3673
• [refactor] [server] Refactor ByteBuf release method in InterleavedLedgerStorage #3674
• [refactor][bookkeeper] Refactor ByteBuf release method in tools #3687
• [refactor] [server] Refactor ByteBuf release method in module bookkeeper-server #3688
• [refactor][bookkeeper] Refactor ByteBuf release method in stream/statelib #3689
• [refactor] [server] Refactor ByteBuf release method in module distributedlog-core #3691
• [refactor] [server] Refactor ByteBuf release method in module distributedlog-core/distributedlog-protocol #3693
• [refactor] [server] Refactor ByteBuf release method in module stream-storage-common/stream-storage-java-kv-client/stream-storage-cli #3694
• [refactor][bookkeeper] Refactor ByteBuf release method in bookkeeper-common-allocator #3695
• [refactor][bookkeeper] Refactor ByteBuf release method in tools  #3698
• [refactor][bookkeeper] Refactor ByteBuf release method in bookkeeper-server #3700
• [refactor][bookkeeper] Refactor ByteBuf release method in stream/storage #3703

Considering some PRs have been cherry-picked into the release branch but others not, it will be hard to cherry-pick if we just push one PR to revert all the above PRs. I will push three Prs for master, branch-4.15, and branch-4.14 to apply this change.

Proposal PR

• BP61: revert BP-59 to release ByteBuf using ReferenceCountUtil.release() instead of ReferenceCountUtil.safeRelease() #3796
• [Branch-4.15] Use ReferenceCountUtil.release() instead of ReferenceCountUtil.safeRelease() #3797
• [Branch-4.14] Use ReferenceCountUtil.release() instead of ReferenceCountUtil.safeRelease() #3798