GH-44759: [GLib] Add garrow_record_batch_validate() #45353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kou
reviewed
Jan 27, 2025
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
|
Ah, I forgot to use |
This was referenced Jan 27, 2025
kou
pushed a commit
that referenced
this pull request
Jan 27, 2025
…#45355) ### Rationale for this change #45353 implemented `garrow_record_batch_validate()` method. But it was the incorrect location. We need to move the code location to use it as a C API. ### What changes are included in this PR? Move the `garrow_record_batch_validate()` location between `G_BEGIN_DECLS` and `G_END_DECLS`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: #45354 Authored-by: Hiroyuki Sato <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit be38880. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
lriggs
pushed a commit
to lriggs/arrow
that referenced
this pull request
Jan 30, 2025
### Rationale for this change [RecordBatch::Validate](https://arrow.apache.org/docs/cpp/api/table.html#_CPPv4NK5arrow11RecordBatch8ValidateEv) available in the C++ API. But, GLib doesn't support that method yet. ### What changes are included in this PR? This PR adds a validation method in the record-batch class. Before this change, the `Validate()` method was used in the `garrow_record_batch_new` implicitly. This PR removes it and adds it as a separate method. Users need to call `garrow_record_batch_validate()` explicitly by themselves. This is a backward incompatible change. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. **This PR includes breaking changes to public APIs.** * GitHub Issue: apache#44759 Authored-by: Hiroyuki Sato <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
lriggs
pushed a commit
to lriggs/arrow
that referenced
this pull request
Jan 30, 2025
…cation (apache#45355) ### Rationale for this change apache#45353 implemented `garrow_record_batch_validate()` method. But it was the incorrect location. We need to move the code location to use it as a C API. ### What changes are included in this PR? Move the `garrow_record_batch_validate()` location between `G_BEGIN_DECLS` and `G_END_DECLS`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#45354 Authored-by: Hiroyuki Sato <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
RecordBatch::Validate available in the C++ API.
But, GLib doesn't support that method yet.
What changes are included in this PR?
This PR adds a validation method in the record-batch class.
Before this change, the
Validate()method was used in thegarrow_record_batch_newimplicitly.This PR removes it and adds it as a separate method. Users need to call
garrow_record_batch_validate()explicitly by themselves. This is a backward incompatible change.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.
This PR includes breaking changes to public APIs.
garrow_record_batch_validate()#44759