Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(object-store): extend Options API for http client #4208

Merged
merged 1 commit into from
May 12, 2023
Merged

feat(object-store): extend Options API for http client #4208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions object_store/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ async-trait = "0.1.53"
bytes = "1.0"
chrono = { version = "0.4.23", default-features = false, features = ["clock"] }
futures = "0.3"
humantime = "2.1"
Copy link
Contributor Author

@roeap roeap May 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we introduce a new dependency, but since humantime itself comes dependency-free i felt we can justify this?

The crate has not seen any updates for quite some time, but is relied upon by some of the msot widely used crates, like cargo, clap, and rustsec.

itertools = "0.10.1"
parking_lot = { version = "0.12" }
percent-encoding = "2.1"
Expand Down
Loading