feat(object-store): extend Options API for http client #4208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeap
commented
May 12, 2023
| @@ -33,6 +33,7 @@ async-trait = "0.1.53" | |||
| bytes = "1.0" | |||
| chrono = { version = "0.4.23", default-features = false, features = ["clock"] } | |||
| futures = "0.3" | |||
| humantime = "2.1" | |||
There was a problem hiding this comment.
Here we introduce a new dependency, but since humantime itself comes dependency-free i felt we can justify this?
The crate has not seen any updates for quite some time, but is relied upon by some of the msot widely used crates, like cargo, clap, and rustsec.
| } | ||
| } | ||
|
|
||
| pub(crate) fn fmt_duration(duration: &ConfigValue<Duration>) -> String { |
There was a problem hiding this comment.
Duration does not implement Display, but we also cannot implement Display for ConfigValue<Duration>, since the compiler believes this may be implemented one day, at which time it would conflict with the generic implementation. Thus i went for a simple function.
roeap
changed the title
tustvold
approved these changes
May 12, 2023
| } | ||
| ClientConfigKey::ProxyUrl => self.proxy_url.clone(), | ||
| ClientConfigKey::Timeout => self.timeout.as_ref().map(fmt_duration), | ||
| ClientConfigKey::UserAgent => self |
There was a problem hiding this comment.
You might be able to make this more legible by using ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
This extends #4202 by @tustvold to allow for configuring more options on the client builder via the Options API.
What changes are included in this PR?
Are there any user-facing changes?