fix: Non wildcard origin in CORS should sent Vary header #9010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boekkooi-lengoo
changed the title
boekkooi-lengoo
changed the title
|
@boekkooi-lengoo Thanks for opening the PR. Tagging @spacewander for review. |
spacewander
reviewed
Mar 7, 2023
When CORS requirements are more complicated than setting `Access-Control-Allow-Origin` to `*` then we set the `Vary` to `Origin`. This avoids caching the wrong response.
boekkooi-lengoo
force-pushed
the
cors-vary
branch
from
b334f73 to
4f20cfb
Compare
|
@spacewander I have update the PR to only include the Vary header fix now. |
spacewander
approved these changes
Mar 14, 2023
leslie-tsang
approved these changes
Mar 16, 2023
hongbinhsu
added a commit
to fitphp/apix
that referenced
this pull request
Mar 17, 2023
* upstream/master: (46 commits) fix(consumer): work if the etcd connection failed during starting (apache#9077) ci: fix low disk space error when loading saved docker images (apache#9080) change: change the default router from radixtree uri to radixtree hos… (apache#9047) chore(deps): bump dubbo from 2.7.18 to 2.7.21 in /t/lib/dubbo-backend/dubbo-backend-provider (apache#9041) fix: cli test on master (apache#9075) fix: Non wildcard origin in CORS should sent Vary header (apache#9010) feat: bump lua-resty-ldap version for ldap-auth (apache#9037) fix: invalidate cache in core.request.add_haeder and fix some calls (apache#8824) docs: remove unnecessary getting-started.md (apache#9054) docs: contribute Getting Started tutorials (apache#9046) docs: replace full-width quotation mark with half-width quotation mark (apache#8887) docs: fix typo and grammar (apache#9008) feat: ready to release 2.15.3 (apache#9021) ci: ensure the test can run with different repo name (apache#8832) chore(deps): bump golang.org/x/net from 0.0.0-20220722155237-a158d28d115b to 0.7.0 in /ci/pod/openfunction/function-example/test-uri (apache#9018) docs: improved SEO & fixed typo and localization issues (apache#8993) feat: release APISIX 3.2.0 (apache#8988) docs: fix grammar (apache#8935) docs: fix indent in encrypted-storage-fields (apache#8876) docs: k8s discovery: state the restriction on the use of port number (apache#8969) ...
AlinsRan
pushed a commit
to AlinsRan/apisix
that referenced
this pull request
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When CORS requirements are more complicated than setting
Access-Control-Allow-Originto*then we set theVarytoOrigin. This avoids caching the wrong response.Last week I was debugging an issue where requests where failing with CORS errors.
After some digging it became clear that when the first request to the endpoint did not match the allowed origins the request was cached and this cached resolve was then used later on for Origins that should be allowed. This turned out to be because the
Varyheader did not containOrigin.Secondly I also resolved an issue where I was unable to use only
allow_origins_by_regexin standalone mode by allowingallow_originsto be an empty string.I'm not sure what
metadata_schemais used for so this maybe wrong.Checklist