Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalidate cache in core.request.add_haeder and fix some calls #8824

Merged
merged 8 commits into from
Mar 13, 2023
Merged

fix: invalidate cache in core.request.add_haeder and fix some calls #8824

merged 8 commits into from
Mar 13, 2023

Conversation

jiangfucheng
Copy link
Member

@jiangfucheng jiangfucheng commented Feb 9, 2023 •
edited
Loading

Description

Fixes #8811

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@jiangfucheng jiangfucheng force-pushed the fix_8811 branch 3 times, most recently from d5296c5 to 9e193e4 Compare February 13, 2023 14:15
@jiangfucheng
Copy link
Member Author

image

This test can pass on my local machine😳.

soulbird
soulbird reviewed Feb 15, 2023
View reviewed changes
@jiangfucheng jiangfucheng force-pushed the fix_8811 branch 2 times, most recently from 6409042 to 93aa57c Compare February 16, 2023 14:02
@jiangfucheng
Copy link
Member Author

@soulbird @spacewander @tokers PTAL, Thanks.

tokers
tokers reviewed Feb 17, 2023
View reviewed changes
soulbird
soulbird previously approved these changes Feb 21, 2023
View reviewed changes
spacewander
spacewander reviewed Feb 21, 2023
View reviewed changes
apisix/core/request.lua Outdated
@@ -143,14 +143,35 @@ function _M.set_header(ctx, header_name, header_value)
end
end

function _M.add_header(header_name, header_value)
function _M.add_header(ctx, header_name, header_value)
Copy link
Member

@spacewander spacewander Feb 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can refactor it and take the common part out.

@jiangfucheng jiangfucheng force-pushed the fix_8811 branch 3 times, most recently from d805c63 to c034826 Compare February 21, 2023 15:50
@jiangfucheng jiangfucheng force-pushed the fix_8811 branch 2 times, most recently from 4fa64eb to eed28bb Compare February 22, 2023 14:03
@jiangfucheng jiangfucheng requested review from spacewander and soulbird and removed request for spacewander February 24, 2023 03:45
@jiangfucheng
Copy link
Member Author

jiangfucheng commented Feb 25, 2023 •
edited
Loading

@spacewander @monkeyDluffy6017 @soulbird Please help me review this PR again, thanks❤️.

spacewander
spacewander reviewed Feb 27, 2023
View reviewed changes
monkeyDluffy6017
monkeyDluffy6017 reviewed Feb 27, 2023
View reviewed changes
soulbird
soulbird reviewed Mar 1, 2023
View reviewed changes
soulbird
soulbird previously approved these changes Mar 1, 2023
View reviewed changes
spacewander
spacewander reviewed Mar 2, 2023
View reviewed changes
@jiangfucheng jiangfucheng requested a review from spacewander March 8, 2023 12:29
@jiangfucheng jiangfucheng requested a review from soulbird March 11, 2023 03:20
@spacewander spacewander merged commit 7e292ea into apache:master Mar 13, 2023
hongbinhsu added a commit to fitphp/apix that referenced this pull request Mar 17, 2023
@hongbinhsu
Merge branch 'upstream/master' into github/master
9c6f9b8 
* upstream/master: (46 commits)
  fix(consumer): work if the etcd connection failed during starting (apache#9077)
  ci: fix low disk space error when loading saved docker images (apache#9080)
  change: change the default router from radixtree uri to radixtree hos… (apache#9047)
  chore(deps): bump dubbo from 2.7.18 to 2.7.21 in /t/lib/dubbo-backend/dubbo-backend-provider (apache#9041)
  fix: cli test on master (apache#9075)
  fix: Non wildcard origin in CORS should sent Vary header (apache#9010)
  feat: bump lua-resty-ldap version for ldap-auth (apache#9037)
  fix: invalidate cache in core.request.add_haeder and fix some calls (apache#8824)
  docs: remove unnecessary getting-started.md (apache#9054)
  docs: contribute Getting Started tutorials (apache#9046)
  docs: replace full-width quotation mark with half-width quotation mark (apache#8887)
  docs: fix typo and grammar (apache#9008)
  feat: ready to release 2.15.3 (apache#9021)
  ci: ensure the test can run with different repo name (apache#8832)
  chore(deps): bump golang.org/x/net from 0.0.0-20220722155237-a158d28d115b to 0.7.0 in /ci/pod/openfunction/function-example/test-uri (apache#9018)
  docs: improved SEO & fixed typo and localization issues (apache#8993)
  feat: release APISIX 3.2.0 (apache#8988)
  docs: fix grammar (apache#8935)
  docs: fix indent in encrypted-storage-fields (apache#8876)
  docs: k8s discovery: state the restriction on the use of port number (apache#8969)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokers tokers tokers left review comments

@spacewander spacewander spacewander approved these changes

@monkeyDluffy6017 monkeyDluffy6017 monkeyDluffy6017 approved these changes

@soulbird soulbird soulbird approved these changes

Assignees
No one assigned
Labels
need backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Lots of "request.lua:120: set_header(): DEPRECATED" warnings in error.log
5 participants
@jiangfucheng @spacewander @monkeyDluffy6017 @tokers @soulbird