Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BigQueryInsertJobOperator job_id return bug #46753

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Fix BigQueryInsertJobOperator job_id return bug #46753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions providers/google/src/airflow/providers/google/cloud/operators/bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2865,6 +2865,7 @@ def execute(self, context: Any):
)
self.log.info("Current state of job %s is %s", job.job_id, job.state)
self._handle_job_error(job)
return self.job_id

def execute_complete(self, context: Context, event: dict[str, Any]) -> str | None:
"""
Expand Down
4 changes: 3 additions & 1 deletion providers/google/tests/provider_tests/google/cloud/operators/test_bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1488,9 +1488,11 @@ def test_bigquery_insert_job_operator_async_finish_before_deferred(self, mock_ho
deferrable=True,
)

op.execute(MagicMock())
result = op.execute(context=MagicMock())

assert not mock_defer.called
assert "Current state of job" in caplog.text
assert result == real_job_id

@mock.patch("airflow.providers.google.cloud.operators.bigquery.BigQueryInsertJobOperator.defer")
@mock.patch("airflow.providers.google.cloud.operators.bigquery.BigQueryHook")
Expand Down
Loading