Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BigQueryInsertJobOperator job_id return bug #46753

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

nakamura1878
Copy link
Contributor

Fix Description

Fixed a bug where the job_id was not returned in the execute method of BigQueryInsertJobOperator. This fix ensures that even if the job finishes before being marked as running, the job_id will be correctly return job_id.

Changes

  • Modified the execute method of BigQueryInsertJobOperator to save the job_id in the context.
  • Updated the execute_complete method to retrieve the job_id from the context.

Tests

  • Modify the test case test_bigquery_insert_job_operator_async_finish_before_deferred to verify that the job_id is correctly returned even if the job finishes before being marked as running.

@boring-cyborg boring-cyborg bot added the provider:google Google (including GCP) related issues label Feb 14, 2025
@potiuk potiuk force-pushed the fix/bigquery-job-id-return-bug branch from 2591de5 to 50a013c Compare February 15, 2025 20:53
@potiuk
Copy link
Member

potiuk commented Feb 15, 2025

Rebased to see if #46608 fixes the failures :)

@potiuk
Copy link
Member

potiuk commented Feb 15, 2025

It looks like it does :)

@potiuk potiuk merged commit 7ae64e9 into apache:main Feb 15, 2025
61 checks passed
dantonbertuol pushed a commit to dantonbertuol/airflow that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants