Call get_current_version less often in bundle refresh loop
#46100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the bundle refresh loop, we can call `get_current_version` a lot less often, as 1) we can skip it for bundles that do not support versioning and 2) for those that do, we already know the version from the last time we refreshed! Since this is a local call, this isn't a huge gain. But every little bit helps.
jedcunningham
added
full tests needed
potiuk
approved these changes
Jan 27, 2025
|
Hmm.. Strange... It works now... Let's merge to see :) |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jan 29, 2025
…pache#46100)" This reverts commit 0834d64.
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jan 29, 2025
…pache#46100)" This reverts commit 0834d64.
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…46100) In the bundle refresh loop, we can call `get_current_version` a lot less often, as 1) we can skip it for bundles that do not support versioning and 2) for those that do, we already know the version from the last time we refreshed! Since this is a local call, this isn't a huge gain. But every little bit helps.
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…pache#46100)" (apache#46221) This reverts commit 0834d64.
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Jan 30, 2025
…46100) In the bundle refresh loop, we can call `get_current_version` a lot less often, as 1) we can skip it for bundles that do not support versioning and 2) for those that do, we already know the version from the last time we refreshed! Since this is a local call, this isn't a huge gain. But every little bit helps.
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Jan 30, 2025
…pache#46100)" (apache#46221) This reverts commit 0834d64.
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
…46100) In the bundle refresh loop, we can call `get_current_version` a lot less often, as 1) we can skip it for bundles that do not support versioning and 2) for those that do, we already know the version from the last time we refreshed! Since this is a local call, this isn't a huge gain. But every little bit helps.
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
…pache#46100)" (apache#46221) This reverts commit 0834d64.
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
…46100) In the bundle refresh loop, we can call `get_current_version` a lot less often, as 1) we can skip it for bundles that do not support versioning and 2) for those that do, we already know the version from the last time we refreshed! Since this is a local call, this isn't a huge gain. But every little bit helps.
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
…pache#46100)" (apache#46221) This reverts commit 0834d64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the bundle refresh loop, we can call
get_current_versiona lot less often, as 1) we can skip it for bundles that do not support versioning and 2) for those that do, we already know the version from the last time we refreshed!Since this is a local call, this isn't a huge gain. But every little bit helps.
Trying this again, as #45999 was reverted in #46037.