Call get_current_version less often in bundle refresh loop
#45999
+87
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the bundle refresh loop, we can call `get_current_version` a lot less often, as 1) we can skip it for bundles that do not support versioning and 2) for those that do, we already know the version from the last time we refreshed! Since this is a local call, this isn't a huge gain. But every little bit helps.
dstandish
approved these changes
Jan 24, 2025
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jan 25, 2025
…pache#45999)" This reverts commit c600a95.
|
Hey @jedcunningham -> reverting it temporarily in #46037 as it seem to break main. You should redo it with "full tests needed" to double check what's going on . It seems theat bundle_model might get None in the test and it could be a side-effect of other test that was not run in the original PR or maybe some other change merged since it succeeded caused it to fail. |
|
Thanks. I'm pretty close to just adding "full tests" on every one of my PRs... |
We are moving fast and breaking things. Actually - until we stabilise thing, maybe it's worth to trigger "full tests" for all code that touches airlfow and "task_sdk"? |
|
There are definitely tradeoffs haha. I've probably just been more unlucky than average due to the changes I've been making though. Generally speaking, I'm not held back by test duration though, so a bit more safety for main is a good trade I'd say. |
jedcunningham
added
AIP-66: DAG Bundle/Manifest
and removed
type:new-feature
gpathak128
pushed a commit
to gpathak128/airflow
that referenced
this pull request
Jan 29, 2025
…45999) In the bundle refresh loop, we can call `get_current_version` a lot less often, as 1) we can skip it for bundles that do not support versioning and 2) for those that do, we already know the version from the last time we refreshed! Since this is a local call, this isn't a huge gain. But every little bit helps.
gpathak128
pushed a commit
to gpathak128/airflow
that referenced
this pull request
Jan 29, 2025
…pache#45999)" (apache#46037) This reverts commit c600a95.
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…45999) In the bundle refresh loop, we can call `get_current_version` a lot less often, as 1) we can skip it for bundles that do not support versioning and 2) for those that do, we already know the version from the last time we refreshed! Since this is a local call, this isn't a huge gain. But every little bit helps.
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…pache#45999)" (apache#46037) This reverts commit c600a95.
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
…45999) In the bundle refresh loop, we can call `get_current_version` a lot less often, as 1) we can skip it for bundles that do not support versioning and 2) for those that do, we already know the version from the last time we refreshed! Since this is a local call, this isn't a huge gain. But every little bit helps.
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
…pache#45999)" (apache#46037) This reverts commit c600a95.
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
…45999) In the bundle refresh loop, we can call `get_current_version` a lot less often, as 1) we can skip it for bundles that do not support versioning and 2) for those that do, we already know the version from the last time we refreshed! Since this is a local call, this isn't a huge gain. But every little bit helps.
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
…pache#45999)" (apache#46037) This reverts commit c600a95.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the bundle refresh loop, we can call
get_current_versiona lot less often, as 1) we can skip it for bundles that do not support versioning and 2) for those that do, we already know the version from the last time we refreshed!Since this is a local call, this isn't a huge gain. But every little bit helps.