Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't get node by their index #42

Closed
koteesy opened this issue May 18, 2021 · 4 comments
Closed

Can't get node by their index #42

koteesy opened this issue May 18, 2021 · 4 comments
Labels
bug

Comments

@koteesy
Copy link

koteesy commented May 18, 2021 •
edited
Loading

Hello, thanks for great library!

For example, we have some piece of xpath, which give me a valid node when i test in browser:

(//table//tbody)[7]

But if i specify it in library, like:

filePath := "./test.html"

doc, er := htmlquery.LoadDoc(filePath)

if er != nil {
  log.Fatal(er)
}

expr, _ := xpath.Compile("(//table//tbody)[7]")

v := expr.Evaluate(htmlquery.CreateXPathNavigator(doc))

values, ok := v.(*xpath.NodeIterator)

if ok {
	for values.MoveNext() {
		log.Println("Founded value is", values.Current().Value())
	}
}else {
	log.Println("Not node iterator.")
}

The output will be empty, because library not found any node. Soo... My question is simple, do i do something wrong, or it bug in library?

HTML 
<!DOCTYPE html>
<html>

<head>
  <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
  <title>Testing</title>
</head>

<body leftmargin="0" topmargin="0" marginwidth="0" marginheight="0">
<!-- Show loading image - place at the bottom of the page -->
<div class="modal_loading"></div>
<div style="margin: 0px auto; width: 600px;">
  <table border="0" width="100%" cellspacing="0" cellpadding="0" align="center">
      <tbody>
      <tr>
          <td align="left" width="100%">
              <table border="0" width="100%" height="100">
                  <tbody>
                  <tr>
                      <td align="left" valign="middle" width="150">  <img width="120" src="/logo.png" border="0" /></td>
                      <td>
                          <form name="form2" id="form2" method="post" data-ajax="false">
                              <input type="hidden" name="mode" value="search" />
                              <table border="0" width="100%">
                                  <tbody>
                                  <tr>
                                      <td height="40" colspan="3"></td>
                                  </tr>
                                  <tr>
                                      <td align="center" width="120">Tracking No.</td>
                                      <td align="right" width="220"><input type="text" id="search_no" name="search_no" placeholder="Enter value" maxlength="30" style="height: 44px" onclick="this.select();" /></td>
                                      <td align="right"><button type="submit" id="btnSubmit" style="width: 100px;">Query</button></td>
                                  </tr>
                                  <tr>
                                      <td align="right" width="180" colspan="3"><span id="show_msg_01"></span></td>
                                  </tr>
                                  <tr>
                                      <td align="right" width="180" colspan="3"><span id="tracking_info"></span></td>
                                  </tr>
                                  <tr>
                                      <td align="right" width="180" colspan="3"><span id="contact_info"></span></td>
                                  </tr>

                                  <tr>
                                      <td align="right" height="20" colspan="3">
                                      </td>
                                  </tr>
                                  </tbody>
                              </table>
                          </form>
                      </td>
                  </tr>
                  </tbody>
              </table>
          </td>
      </tr>
      <tr>
          <td width="100%" colspan="2">
              <table width="100%" border="0" cellspacing="0" cellpadding="0">
                  <tbody>
                  <tr>
                      <td height="12" width="100%" style="color: #c09853;"></td>
                  </tr>
                  <tr>
                      <td width="100%">
                          <div align="center">
                              <table width="100%" border="0" cellspacing="0" cellpadding="0">
                                  <tbody>
                                  <tr>
                                      <td colspan="4" height="20" width="100%">
                                          <table width="100%" cellspacing="1" cellpadding="3">
                                              <tbody>
                                              <tr height="25">
                                                  <th width="150" align="left">First name:</th>
                                                  <td>First name..</td>
                                              </tr>
                                              <tr height="25">
                                                  <th width="150" align="left">Second:</th>
                                                  <td>Second name..</td>
                                              </tr>
                                              </tbody>
                                          </table>
                                      </td>
                                  </tr>
                                  <tr>
                                      <td height="10" colspan="4"></td>
                                  </tr>
                                  <tr>
                                      <td colspan="4">
                                          <table width="100%" cellspacing="1" cellpadding="3" border="0" bgcolor="#929699">
                                              <tbody>
                                              <tr height="30" align="center" bgcolor="#e0e0e0">
                                                  <th class="text-center" width="5%">No.</th>
                                                  <th class="text-center" width="12%">Date</th>
                                                  <th class="text-center" width="8%">Time</th>
                                                  <th class="text-center" width="8%">Area</th>
                                                  <th class="text-center" width="22%">Status</th>
                                                  <th class="text-center" width="19%">Status(KOR)</th>
                                                  <th class="text-center" width="30%">Remarks</th>
                                                  <!-- 2018.01.22 이승민-------------------------------------- -->
                                                  <!-- ---------------------------------------------------- -->
                                              </tr>
                                              <tr height="50" bgcolor="#FFFFFF" align="center">
                                                  <td style="font-size: 100%;">1</td>
                                                  <td>2021.03.22</td>
                                                  <td>10:22</td>
                                                  <td>Korea</td>
                                                  <td>Oks</td>
                                                  <td>Test</td>
                                                  <td>Some new info</td>
                                              </tr>
                                              </tbody>
                                          </table>
                                      </td>
                                  </tr>
                                  </tbody>
                              </table>
                          </div>
                      </td>
                  </tr>
                  </tbody>
              </table>
          </td>
      </tr>
      </tbody>
  </table>
</div>
</body>

</html>
@zhengchun zhengchun added the bug label May 19, 2021
@koteesy
Copy link
Author

koteesy commented Jun 2, 2021

Hello :d

Any updates?

zhengchun added a commit to antchfx/xpath that referenced this issue Jun 3, 2021
@zhengchun
add groupQuery, supports grouping node query, (xpath expression). f…
50cf86e 
…ix #antchfx/htmlquery#42
@zhengchun
Copy link
Contributor

Fixed. you can checkout the latest of xpath package to fix this.

antchfx/xpath@50cf86e

@renovate renovate bot mentioned this issue Jun 3, 2021
Merged
1 task
@koteesy
Copy link
Author

koteesy commented Jun 3, 2021

Fixed. you can checkout the latest of xpath package to fix this.

antchfx/xpath@50cf86e

Thank you so much! I will check it.

@koteesy
Copy link
Author

koteesy commented Jun 18, 2021

Look's like everything working fine. Thanks you!

@koteesy koteesy closed this as completed Jun 18, 2021
@JWAlberty JWAlberty mentioned this issue Jan 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhengchun @koteesy