FindOne with expression containing groups only works the first time #56

JWAlberty · 2023-01-10T18:03:31Z

If I do an expression like (//*/div) it works the first time but subsequent calls with the same expression return nil. They always return the same result however if i simply drop the paranthesis. This is problematic because I need the paranthesis do pick an element by its index (//*/div)[1]. This seems to have been introduced in the fix for #42 which was done in version 1.2.0 of the xpath library that htmlquery uses.
Here's a sample piece of code where it fails.

package main

import (
	"fmt"
	"strings"

	"github.com/antchfx/htmlquery"
	"golang.org/x/net/html"
)

func main() {
	fmt.Printf("Run 1: %#v\n", getDiv(`(//*/div)`)) // works
	fmt.Printf("Run 2: %#v\n", getDiv(`(//*/div)`)) // fails

	fmt.Printf("Run 1: %#v\n", getDiv(`//*/div`)) // works
	fmt.Printf("Run 2: %#v\n", getDiv(`//*/div`)) // also works
}

func getDiv(selector string) *html.Node {
	s := `<html><head></head><body><div>a</div></body>`
	doc, err := htmlquery.Parse(strings.NewReader(s))
	if err != nil {
		panic(err)
	}
	return htmlquery.FindOne(doc, selector)
}

The text was updated successfully, but these errors were encountered:

zhengchun · 2023-01-11T15:08:02Z

Thanks for report. Just update your xpath package to v1.2.2 to fix this.

https://github.com/antchfx/xpath/releases/tag/v1.2.2

JWAlberty · 2023-01-11T15:41:11Z

@zhengchun thank you. Just tested 1.2.2 in my project and can confirm v1.2.2 fixes it

zhengchun added the bug label Jan 11, 2023

JWAlberty closed this as completed Jan 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FindOne with expression containing groups only works the first time #56

FindOne with expression containing groups only works the first time #56

JWAlberty commented Jan 10, 2023 •

edited

Loading

zhengchun commented Jan 11, 2023

JWAlberty commented Jan 11, 2023

FindOne with expression containing groups only works the first time #56

FindOne with expression containing groups only works the first time #56

Comments

JWAlberty commented Jan 10, 2023 • edited Loading

zhengchun commented Jan 11, 2023

JWAlberty commented Jan 11, 2023

JWAlberty commented Jan 10, 2023 •

edited

Loading