Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Menu add token subMenuItemSelectedColor #52182

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Dec 31, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English Menu add token subMenuItemSelectedColor to reslove submenu title color being overrided by itemSelectedColor .
🇨🇳 Chinese Menu 新增 token subMenuItemSelectedColor,避免 itemSelectedColor 覆盖子菜单标题样式。

Copy link

stackblitz bot commented Dec 31, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Dec 31, 2024

👁 Visual Regression Report for PR #52182 Failed ❌

🎯 Target branch: feature (70d01a1)
📖 View Full Report ↗︎

Expected (Branch feature) Actual (Current PR) Diff
button-color-variant.dark.png button-color-variant.dark.png button-color-variant.dark.css-var.png button-color-variant.dark.css-var.png
button-debug-color-variant.compact.png button-debug-color-variant.compact.png button-debug-color-variant.compact.css-var.png button-debug-color-variant.compact.css-var.png
button-debug-color-variant.dark.png button-debug-color-variant.dark.png button-debug-color-variant.dark.css-var.png button-debug-color-variant.dark.css-var.png
button-debug-color-variant.default.png button-debug-color-variant.default.png button-debug-color-variant.default.css-var.png button-debug-color-variant.default.css-var.png
checkbox-custom-line-width.compact.png checkbox-custom-line-width.compact.png checkbox-custom-line-width.compact.css-var.png checkbox-custom-line-width.compact.css-var.png
checkbox-custom-line-width.dark.png checkbox-custom-line-width.dark.png checkbox-custom-line-width.dark.css-var.png checkbox-custom-line-width.dark.css-var.png
checkbox-custom-line-width.default.png checkbox-custom-line-width.default.png checkbox-custom-line-width.default.css-var.png checkbox-custom-line-width.default.css-var.png
checkbox-debug-line.compact.png checkbox-debug-line.compact.png checkbox-debug-line.compact.css-var.png checkbox-debug-line.compact.css-var.png

Warning

There are more diffs not shown in the table. Please check the Full Report for details.


Important

There are 59 diffs found in this PR: 🔄 59 changed.
Please check all items:

  • Checked all diffs in the full report
  • Visual diff is acceptable

Copy link
Contributor

github-actions bot commented Dec 31, 2024

Preview is ready

Copy link

Walkthrough

This pull request introduces a new style token subMenuItemSelectedColor to the Menu component. This addition aims to resolve conflicts with the existing itemSelectedColor by providing a distinct color option for submenu titles when an item within the submenu is selected.

Changes

File Summary
components/menu/style/index.ts Added subMenuItemSelectedColor to the menu style definitions to handle submenu item selection color conflicts.
components/menu/style/theme.ts Updated theme styles to utilize subMenuItemSelectedColor for submenu titles when selected.

Copy link

cloudflare-workers-and-pages bot commented Dec 31, 2024

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5d1f4a0
Status: ✅  Deploy successful!
Preview URL: https://80bcbff1.ant-design.pages.dev
Branch Preview URL: https://feat-token-menu-submenuitems.ant-design.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Dec 31, 2024

size-limit report 📦

Path Size
dist/antd.min.js 443.12 KB (-1 B 🔽)
dist/antd-with-locales.min.js 511.22 KB (+10 B 🔺)

Copy link

pkg-pr-new bot commented Dec 31, 2024

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b5af1f5) to head (5d1f4a0).
Report is 2 commits behind head on feature.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #52182   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          763       763           
  Lines        13735     13735           
  Branches      3587      3587           
=========================================
  Hits         13735     13735           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants