Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

menu的token在light/dark模式下有bug #45488

Closed
chj-damon opened this issue Oct 23, 2023 · 2 comments
Closed

menu的token在light/dark模式下有bug #45488

chj-damon opened this issue Oct 23, 2023 · 2 comments
Labels
improvement improve some features Inactive

Comments

@chj-damon
Copy link
Contributor

Reproduction link

Edit on CodeSandbox

Steps to reproduce

  1. 鼠标hover MenuItem或者SubMenu，或者鼠标选中MenuItem
  2. 点击切换主题按钮将主题切换为dark模式
  3. 重复步骤1

What is expected?

  1. light主题下，选中一个MenuItem时，它所在的SubMenu的文字颜色不应该是白色，或者文字颜色是白色，但背景色是主题设置的背景色
  2. dark主题下，鼠标hover MenuItem或者SubMenu的时候，背景色应该是设置的背景色

What is actually happening?

  1. light主题下，鼠标hover MenuItem或者SubMenu时背景为设置的背景色，但是一旦选中一个MenuItem后，该MenuItem的背景色会正确改变，但是这时候SubMenu的文字颜色变成了白色
  2. dark主题下，鼠标hover MenuItem或者SubMenu时背景不是设置的背景色
Environment Info
antd 5.10.2
React 18.0.0
System macos13.4.1
Browser chrome 117.0.5938.92
@MadCcc
Copy link
Member

MadCcc commented Oct 23, 2023

暗色模式 Menu 有专用的 token
image

亮色模式下由于选择 submenu 时会让分组也处于选中状态，所以文字颜色也应用了 itemSelectedColor，看起来得区分下。

@MadCcc MadCcc added improvement improve some features and removed unconfirmed labels Oct 23, 2023
@cheng87126 cheng87126 mentioned this issue Oct 27, 2023
Closed
15 tasks
@MadCcc MadCcc mentioned this issue Dec 11, 2023
Closed
@afc163 afc163 mentioned this issue Dec 31, 2024
Merged
16 tasks
afc163 added a commit that referenced this issue Dec 31, 2024
@afc163
feat: Menu add token subMenuItemSelectedColor (#52182)
ab3b6ab 
- close #45488
- close #46354
- close #52166
@afc163
Copy link
Member

afc163 commented Dec 31, 2024

Fixed in #52182

@afc163 afc163 closed this as completed Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement improve some features Inactive
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@afc163 @chj-damon @MadCcc