aws test splitter - add lookup plugins #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
|
Build succeeded.
|
|
@goneri this aims to add targets for lookup, it was missing from your PR and needed to test the PR ansible-collections/amazon.aws#591 |
|
Build succeeded.
|
goneri
reviewed
Feb 22, 2022
| """List the lookup plugins impacted by the change""" | ||
| for d in self.changed_files(): | ||
| if str(d).startswith("plugins/lookup/"): | ||
| yield PosixPath(d) |
goneri
reviewed
Feb 22, 2022
| @@ -53,6 +54,7 @@ def test_what_changed_files(): | |||
| "ansible_collections.a.b.plugins.module_utils.core", | |||
| ) | |||
| ] | |||
| assert list(whc.lookup()) == [PosixPath("plugins/lookup/aws_test.py")] | |||
There was a problem hiding this comment.
Ideally, we should also check that the right target is enabled.
goneri
reviewed
Feb 22, 2022
| @@ -258,6 +267,9 @@ def build_result_struct(self, batches): | |||
| for c in collections: | |||
| c.add_target_to_plan(f"module_utils_{path.stem}") | |||
| c.cover_module_utils(pymod) | |||
| for path in whc.lookup(): | |||
| for c in collections: | |||
| c.add_target_to_plan(f"lookup_{path.stem}") | |||
There was a problem hiding this comment.
Ideally, this should also be covered. Actually the whole block should be tested.
goneri
approved these changes
Feb 22, 2022
|
Build succeeded (gate pipeline).
|
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/amazon.aws
that referenced
this pull request
Mar 1, 2022
aws_secret: Handle pagination for bypath=true Depends-On: ansible/ansible-zuul-jobs#1359 Depends-On: ansible/ansible-zuul-jobs#1362 Depends-On: ansible/ansible-zuul-jobs#1364 SUMMARY Currently aws_secret returns only 10 secrets, added manual pagination for getting all the secrets as per the task. Fixes #472. ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_secret Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None>
patchback bot
pushed a commit
to ansible-collections/amazon.aws
that referenced
this pull request
Mar 1, 2022
aws_secret: Handle pagination for bypath=true Depends-On: ansible/ansible-zuul-jobs#1359 Depends-On: ansible/ansible-zuul-jobs#1362 Depends-On: ansible/ansible-zuul-jobs#1364 SUMMARY Currently aws_secret returns only 10 secrets, added manual pagination for getting all the secrets as per the task. Fixes #472. ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_secret Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> (cherry picked from commit 9f0a616)
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/amazon.aws
that referenced
this pull request
Mar 2, 2022
[PR #591/9f0a616e backport][stable-3] aws_secret: Handle pagination for bypath=true This is a backport of PR #591 as merged into main (9f0a616). Depends-On: ansible/ansible-zuul-jobs#1359 Depends-On: ansible/ansible-zuul-jobs#1362 Depends-On: ansible/ansible-zuul-jobs#1364 SUMMARY Currently aws_secret returns only 10 secrets, added manual pagination for getting all the secrets as per the task. Fixes #472. ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_secret
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.