[PR #591/9f0a616e backport][stable-3] aws_secret: Handle pagination for bypath=true #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
aws_secret: Handle pagination for bypath=true Depends-On: ansible/ansible-zuul-jobs#1359 Depends-On: ansible/ansible-zuul-jobs#1362 Depends-On: ansible/ansible-zuul-jobs#1364 SUMMARY Currently aws_secret returns only 10 secrets, added manual pagination for getting all the secrets as per the task. Fixes #472. ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_secret Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> (cherry picked from commit 9f0a616)
ansibullbot
added
bug
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-3/9f0a616e84bd769358509bed6708dd88d7b36179/pr-591
branch
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
) ELB info: return all LB if names is not defined SUMMARY Documentation says options: names: description: - List of ELB names to gather information about. Pass this option to gather information about a set of ELBs, otherwise, all ELBs are returned. But doing this elb_classic_lb_info returns an empty list. ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_classic_lb_info ADDITIONAL INFORMATION - hosts: localhost tasks: - community.aws.elb_classic_lb_info: {} register: elb_info - debug: var=elb_info $ ansible-playbook playbook.yaml TASK [community.aws.elb_classic_lb_info] ******** ok: [localhost] TASK [debug] ******** ok: [localhost] => { "elb_info": { "changed": false, "elbs": [], # <-- should return list of all ELB "failed": false } } Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
) ELB info: return all LB if names is not defined SUMMARY Documentation says options: names: description: - List of ELB names to gather information about. Pass this option to gather information about a set of ELBs, otherwise, all ELBs are returned. But doing this elb_classic_lb_info returns an empty list. ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_classic_lb_info ADDITIONAL INFORMATION - hosts: localhost tasks: - community.aws.elb_classic_lb_info: {} register: elb_info - debug: var=elb_info $ ansible-playbook playbook.yaml TASK [community.aws.elb_classic_lb_info] ******** ok: [localhost] TASK [debug] ******** ok: [localhost] => { "elb_info": { "changed": false, "elbs": [], # <-- should return list of all ELB "failed": false } } Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
) ELB info: return all LB if names is not defined SUMMARY Documentation says options: names: description: - List of ELB names to gather information about. Pass this option to gather information about a set of ELBs, otherwise, all ELBs are returned. But doing this elb_classic_lb_info returns an empty list. ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_classic_lb_info ADDITIONAL INFORMATION - hosts: localhost tasks: - community.aws.elb_classic_lb_info: {} register: elb_info - debug: var=elb_info $ ansible-playbook playbook.yaml TASK [community.aws.elb_classic_lb_info] ******** ok: [localhost] TASK [debug] ******** ok: [localhost] => { "elb_info": { "changed": false, "elbs": [], # <-- should return list of all ELB "failed": false } } Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> Reviewed-by: None <None>
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Aug 29, 2024
) ELB info: return all LB if names is not defined SUMMARY Documentation says options: names: description: - List of ELB names to gather information about. Pass this option to gather information about a set of ELBs, otherwise, all ELBs are returned. But doing this elb_classic_lb_info returns an empty list. ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_classic_lb_info ADDITIONAL INFORMATION - hosts: localhost tasks: - community.aws.elb_classic_lb_info: {} register: elb_info - debug: var=elb_info $ ansible-playbook playbook.yaml TASK [community.aws.elb_classic_lb_info] ******** ok: [localhost] TASK [debug] ******** ok: [localhost] => { "elb_info": { "changed": false, "elbs": [], # <-- should return list of all ELB "failed": false } } Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@bebdd75
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Aug 30, 2024
) ELB info: return all LB if names is not defined SUMMARY Documentation says options: names: description: - List of ELB names to gather information about. Pass this option to gather information about a set of ELBs, otherwise, all ELBs are returned. But doing this elb_classic_lb_info returns an empty list. ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_classic_lb_info ADDITIONAL INFORMATION - hosts: localhost tasks: - community.aws.elb_classic_lb_info: {} register: elb_info - debug: var=elb_info $ ansible-playbook playbook.yaml TASK [community.aws.elb_classic_lb_info] ******** ok: [localhost] TASK [debug] ******** ok: [localhost] => { "elb_info": { "changed": false, "elbs": [], # <-- should return list of all ELB "failed": false } } Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@bebdd75
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Sep 3, 2024
) ELB info: return all LB if names is not defined SUMMARY Documentation says options: names: description: - List of ELB names to gather information about. Pass this option to gather information about a set of ELBs, otherwise, all ELBs are returned. But doing this elb_classic_lb_info returns an empty list. ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_classic_lb_info ADDITIONAL INFORMATION - hosts: localhost tasks: - community.aws.elb_classic_lb_info: {} register: elb_info - debug: var=elb_info $ ansible-playbook playbook.yaml TASK [community.aws.elb_classic_lb_info] ******** ok: [localhost] TASK [debug] ******** ok: [localhost] => { "elb_info": { "changed": false, "elbs": [], # <-- should return list of all ELB "failed": false } } Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@bebdd75
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Sep 30, 2024
) ELB info: return all LB if names is not defined SUMMARY Documentation says options: names: description: - List of ELB names to gather information about. Pass this option to gather information about a set of ELBs, otherwise, all ELBs are returned. But doing this elb_classic_lb_info returns an empty list. ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_classic_lb_info ADDITIONAL INFORMATION - hosts: localhost tasks: - community.aws.elb_classic_lb_info: {} register: elb_info - debug: var=elb_info $ ansible-playbook playbook.yaml TASK [community.aws.elb_classic_lb_info] ******** ok: [localhost] TASK [debug] ******** ok: [localhost] => { "elb_info": { "changed": false, "elbs": [], # <-- should return list of all ELB "failed": false } } Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@bebdd75
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 7, 2024
) ELB info: return all LB if names is not defined SUMMARY Documentation says options: names: description: - List of ELB names to gather information about. Pass this option to gather information about a set of ELBs, otherwise, all ELBs are returned. But doing this elb_classic_lb_info returns an empty list. ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_classic_lb_info ADDITIONAL INFORMATION - hosts: localhost tasks: - community.aws.elb_classic_lb_info: {} register: elb_info - debug: var=elb_info $ ansible-playbook playbook.yaml TASK [community.aws.elb_classic_lb_info] ******** ok: [localhost] TASK [debug] ******** ok: [localhost] => { "elb_info": { "changed": false, "elbs": [], # <-- should return list of all ELB "failed": false } } Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@bebdd75
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 21, 2024
) ELB info: return all LB if names is not defined SUMMARY Documentation says options: names: description: - List of ELB names to gather information about. Pass this option to gather information about a set of ELBs, otherwise, all ELBs are returned. But doing this elb_classic_lb_info returns an empty list. ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_classic_lb_info ADDITIONAL INFORMATION - hosts: localhost tasks: - community.aws.elb_classic_lb_info: {} register: elb_info - debug: var=elb_info $ ansible-playbook playbook.yaml TASK [community.aws.elb_classic_lb_info] ******** ok: [localhost] TASK [debug] ******** ok: [localhost] => { "elb_info": { "changed": false, "elbs": [], # <-- should return list of all ELB "failed": false } } Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@bebdd75
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 21, 2024
) ELB info: return all LB if names is not defined SUMMARY Documentation says options: names: description: - List of ELB names to gather information about. Pass this option to gather information about a set of ELBs, otherwise, all ELBs are returned. But doing this elb_classic_lb_info returns an empty list. ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_classic_lb_info ADDITIONAL INFORMATION - hosts: localhost tasks: - community.aws.elb_classic_lb_info: {} register: elb_info - debug: var=elb_info $ ansible-playbook playbook.yaml TASK [community.aws.elb_classic_lb_info] ******** ok: [localhost] TASK [debug] ******** ok: [localhost] => { "elb_info": { "changed": false, "elbs": [], # <-- should return list of all ELB "failed": false } } Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@bebdd75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #591 as merged into main (9f0a616).
Depends-On: ansible/ansible-zuul-jobs#1359
Depends-On: ansible/ansible-zuul-jobs#1362
Depends-On: ansible/ansible-zuul-jobs#1364
SUMMARY
Currently aws_secret returns only 10 secrets, added manual pagination for getting all the secrets as per the task.
Fixes #472.
ISSUE TYPE
COMPONENT NAME
aws_secret