Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
current way of setting the superuser directly in grub.cfg does not work, the way it is set, it will be ignored, the following config is generated:
grub.cfg should not be edited directly, files in /etc/grub.d should be used (in this case /etc/grub.d/01_users
with this pull request config is generated as follows and handlers are correctly fired to generate grub.cfg:
Issue Fixes:
Enhancements:
How has this been tested?:
Without this pull request, only username 'root' works, any other username will not work/will be ignored and 'root' will be used