Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHEL-08-010421 Same grubby behavior than on other tasks #58

Closed
JSurf opened this issue Sep 29, 2021 · 1 comment
Closed

RHEL-08-010421 Same grubby behavior than on other tasks #58

JSurf opened this issue Sep 29, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@JSurf
Copy link
Contributor

JSurf commented Sep 29, 2021

Describe the Issue
RHEL-08-010421 always executes grubby without checking if page_poison=1 is already set

Expected Behavior
RHEL-08-010421 should check if page_poison=1 is already set
Task should implement similar 'when' conditions as for example RHEL-08-010422 and others before running grubby

Actual Behavior
RHEL-08-010421 does not check if page_poison=1 is already set and always runs grubby which may cause for example unexpected config changes to /etc/default/grub (moving page_poison to the end of the line)

Control(s) Affected
RHEL-08-010421

Environment (please complete the following information):
does not matter

Additional Notes
Maybe there is a reason unknown to me, this is the only rule with grubby that does not do a check ?

Possible Solution
vitecde@cfe8e3d
If you prefer a pull request please let me know

@JSurf JSurf added the bug Something isn't working label Sep 29, 2021
@georgenalen georgenalen self-assigned this Oct 18, 2021
georgenalen added a commit that referenced this issue Oct 18, 2021
@georgenalen
Copy link
Contributor

Addressed in release 2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants