Fix sanity errors

changelogs/fragments/55-linting.yml

@@ -0,0 +1,3 @@
+minor_changes:
+  - "command - the ``commands`` and ``wait_for`` options now convert the list elements to strings (https://github.com/ansible-collections/community.routeros/pull/55)."
+  - "facts - the ``gather_subset`` option now converts the list elements to strings (https://github.com/ansible-collections/community.routeros/pull/55)."

plugins/modules/command.py

@@ -27,13 +27,17 @@
         module is not returned until the condition is satisfied or
         the number of retries has expired.
     required: true
+    type: list
+    elements: str
   wait_for:
     description:
       - List of conditions to evaluate against the output of the
         command. The task will wait for each condition to be true
         before moving forward. If the conditional is not true
         within the configured number of retries, the task fails.
         See examples.
+    type: list
+    elements: str
   match:
     description:
       - The I(match) argument is used in conjunction with the
@@ -44,20 +48,23 @@
         satisfied.
     default: all
     choices: ['any', 'all']
+    type: str
   retries:
     description:
       - Specifies the number of retries a command should by tried
         before it is considered failed. The command is run on the
         target device every retry and evaluated against the
         I(wait_for) conditions.
     default: 10
+    type: int
   interval:
     description:
       - Configures the interval in seconds to wait between retries
         of the command. If the command does not pass the specified
         conditions, the interval indicates how long to wait before
         trying the command again.
     default: 1
+    type: int
 seealso:
   - ref: ansible_collections.community.routeros.docsite.ssh-guide
     description: How to connect to RouterOS devices with SSH
@@ -131,10 +138,10 @@ def main():
     """main entry point for module execution
     """
     argument_spec = dict(
-        commands=dict(type='list', required=True),
+        commands=dict(type='list', elements='str', required=True),
 
-        wait_for=dict(type='list'),
-        match=dict(default='all', choices=['all', 'any']),
+        wait_for=dict(type='list', elements='str'),
+        match=dict(type='str', default='all', choices=['all', 'any']),
 
         retries=dict(default=10, type='int'),
         interval=dict(default=1, type='int')

plugins/modules/facts.py

@@ -27,6 +27,8 @@
         not be collected.
     required: false
     default: '!config'
+    type: list
+    elements: str
 seealso:
   - ref: ansible_collections.community.routeros.docsite.ssh-guide
     description: How to connect to RouterOS devices with SSH
@@ -586,7 +588,7 @@ def main():
     """main entry point for module execution
     """
     argument_spec = dict(
-        gather_subset=dict(default=['!config'], type='list')
+        gather_subset=dict(default=['!config'], type='list', elements='str')
     )
 
     argument_spec.update(routeros_argument_spec)