Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sanity errors #55

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

So far we were ignoring several sanity errors. Let's fix them instead :)

For the list options, adding elements='str' makes AnsibleModule convert list elements to strings. This is a behavior change, that's why this is a feature and not just a bugfix or docs PR (though I guess if you passed something else before, it would have crashed the module or resulted in other errors :) ).

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

command
facts

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #55 (f17d557) into main (65034de) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   83.37%   83.37%           
=======================================
  Files          14       14           
  Lines        1480     1480           
  Branches      198      198           
=======================================
  Hits         1234     1234           
  Misses        189      189           
  Partials       57       57           
Impacted Files Coverage Δ
plugins/modules/command.py 93.75% <ø> (ø)
plugins/modules/facts.py 82.43% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65034de...f17d557. Read the comment docs.

Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty ignore.txt, excellent :)

@gundalow gundalow merged commit 4ccd70c into ansible-collections:main Oct 19, 2021
@felixfontein felixfontein deleted the sanity branch October 19, 2021 12:05
@felixfontein
Copy link
Collaborator Author

@gundalow thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants