Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9621/fb4f7248 backport][stable-8] keycloak_client: sanitize saml.encryption.private.key #9628

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jan 26, 2025

This is a backport of PR #9621 as merged into main (fb4f724).

SUMMARY

The module sanitizes only saml.singning.private.key, but not saml.encryption.private.key.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

keycloak_client

ADDITIONAL INFORMATION

shortened output before PR:

{
  "attributes": {
    "saml.encrypt": "true",
    "saml.encryption.certificate": "MIICoTCCAYk [...] BDJpxpqdXeRw=",
    "saml.encryption.private.key": "MIIEpAIBA [...] FYUiJ8nmzMfZLGtMs3bAtDpg==",
    "saml.signing.certificate": "MIICoTC [...] RT9mk1UYNU=",
    "saml.signing.private.key": "no_log",
    "saml_force_name_id_format": "false"
  }
}

* sanitize saml.encryption.private.key in module output

* add changelog fragment

* Re-categorize changelog fragment.

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit fb4f724)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Jan 26, 2025
@felixfontein felixfontein merged commit cd729c5 into stable-8 Jan 26, 2025
129 checks passed
@felixfontein felixfontein deleted the patchback/backports/stable-8/fb4f7248c9f1483345f2cb0da8f3f92c0c32a935/pr-9621 branch January 26, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants