Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keycloak_client: sanitize saml.encryption.private.key #9621

Merged
merged 3 commits into from
Jan 26, 2025
Merged

keycloak_client: sanitize saml.encryption.private.key #9621

merged 3 commits into from
Jan 26, 2025

Conversation

fgruenbauer
Copy link
Contributor

SUMMARY

The module sanitizes only saml.singning.private.key, but not saml.encryption.private.key.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

keycloak_client

ADDITIONAL INFORMATION

shortened output before PR:

{
  "attributes": {
    "saml.encrypt": "true",
    "saml.encryption.certificate": "MIICoTCCAYk [...] BDJpxpqdXeRw=",
    "saml.encryption.private.key": "MIIEpAIBA [...] FYUiJ8nmzMfZLGtMs3bAtDpg==",
    "saml.signing.certificate": "MIICoTC [...] RT9mk1UYNU=",
    "saml.signing.private.key": "no_log",
    "saml_force_name_id_format": "false"
  }
}

@ansibullbot
Copy link
Collaborator

cc @eikef @mattock @ndclt @thomasbach-dev
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module plugins plugin (any type) labels Jan 24, 2025
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-9 Automatically create a backport for the stable-9 branch backport-10 Automatically create a backport for the stable-10 branch labels Jan 24, 2025
felixfontein
felixfontein reviewed Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

changelogs/fragments/9621-keycloak_client-sanitize-saml-encryption-key.yml Outdated Show resolved Hide resolved
@felixfontein felixfontein added the backport-8 Automatically create a backport for the stable-8 branch label Jan 24, 2025
@felixfontein felixfontein merged commit fb4f724 into ansible-collections:main Jan 26, 2025
138 checks passed
@patchback Patchback
Copy link

patchback bot commented Jan 26, 2025 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/fb4f7248c9f1483345f2cb0da8f3f92c0c32a935/pr-9621

Backported as #9628

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 26, 2025
@fgruenbauer @patchback
keycloak_client: sanitize saml.encryption.private.key (#9621)
5c3458c 
* sanitize saml.encryption.private.key in module output

* add changelog fragment

* Re-categorize changelog fragment.

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit fb4f724)
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jan 26, 2025
@patchback patchback bot mentioned this pull request Jan 26, 2025
Merged
@patchback Patchback
Copy link

patchback bot commented Jan 26, 2025 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/fb4f7248c9f1483345f2cb0da8f3f92c0c32a935/pr-9621

Backported as #9629

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 26, 2025
@fgruenbauer @patchback
keycloak_client: sanitize saml.encryption.private.key (#9621)
8732c98 
* sanitize saml.encryption.private.key in module output

* add changelog fragment

* Re-categorize changelog fragment.

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit fb4f724)
@patchback Patchback
Copy link

patchback bot commented Jan 26, 2025 •
edited
Loading

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/fb4f7248c9f1483345f2cb0da8f3f92c0c32a935/pr-9621

Backported as #9630

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Jan 26, 2025
Merged
patchback bot pushed a commit that referenced this pull request Jan 26, 2025
@fgruenbauer @patchback
keycloak_client: sanitize saml.encryption.private.key (#9621)
93f7f43 
* sanitize saml.encryption.private.key in module output

* add changelog fragment

* Re-categorize changelog fragment.

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit fb4f724)
@patchback patchback bot mentioned this pull request Jan 26, 2025
Merged
@felixfontein
Copy link
Collaborator

@fgruenbauer thanks for fixing this!

felixfontein pushed a commit that referenced this pull request Jan 26, 2025
@patchback @fgruenbauer
[PR #9621/fb4f7248 backport][stable-8] keycloak_client: sanitize `sam…
cd729c5 
…l.encryption.private.key` (#9628)

keycloak_client: sanitize `saml.encryption.private.key` (#9621)

* sanitize saml.encryption.private.key in module output

* add changelog fragment

* Re-categorize changelog fragment.

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit fb4f724)

Co-authored-by: fgruenbauer <[email protected]>
felixfontein pushed a commit that referenced this pull request Jan 26, 2025
@patchback @fgruenbauer
[PR #9621/fb4f7248 backport][stable-9] keycloak_client: sanitize `sam…
b23eb4b 
…l.encryption.private.key` (#9629)

keycloak_client: sanitize `saml.encryption.private.key` (#9621)

* sanitize saml.encryption.private.key in module output

* add changelog fragment

* Re-categorize changelog fragment.

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit fb4f724)

Co-authored-by: fgruenbauer <[email protected]>
felixfontein pushed a commit that referenced this pull request Jan 26, 2025
@patchback @fgruenbauer
[PR #9621/fb4f7248 backport][stable-10] keycloak_client: sanitize `sa…
8e2fa62 
…ml.encryption.private.key` (#9630)

keycloak_client: sanitize `saml.encryption.private.key` (#9621)

* sanitize saml.encryption.private.key in module output

* add changelog fragment

* Re-categorize changelog fragment.

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit fb4f724)

Co-authored-by: fgruenbauer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch backport-10 Automatically create a backport for the stable-10 branch bug This issue/PR relates to a bug module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fgruenbauer @ansibullbot @felixfontein